61967 - Hitting enter on blank "to" field does not move focus to message body

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Ben Ruppel]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; m18) Gecko/20001204
BuildID:    2000120404

Hitting "enter" after typing in a recipient's address in a message moves the
caret to another "to:" field.  In NS4.x, hitting enter again with a blank field
would bring the caret to the subject line.  I think this is a regression.	

Reproducible: Always
Steps to Reproduce:
Open message, type in recipient name, hit enter.  Caret moves to another "to:"
field.

Hit enter again without typing.

Actual Results:  Nothing happens.		

Expected Results:  Focus and Caret move to Subject field.

Comment 1

[scottputterman]

reassigning to ducarroz.

Comment 2

[Fabian Guisset]

Confirmed, I even have a fix for this if anyone cares. UI masters, I think this
would be cool, it's easier to hit enter twice than to find the tab key, imho.
Fabian.
Why doesn't this go to the mail compose component?

Comment 3

[Jean-Francois Ducarroz]

because autocomplete doesn't have its own module and as this specific problem
apply only to mail. Anyway, if you have a fix, please post the patch in this bug
report. Thanks

Comment 4

[Fabian Guisset]

Attachment: Diff file to fix bug 61967

Comment 5

[Fabian Guisset]

A diff file is the best I can produce, as I don't have a cvs repository.
Normally this should fix the issue :
1) Delete the blank field
2) Focus in the status bar, and select its content if anything was typed in
previously

Tell me what you think, I'll be glad to incorporate whatever comment you make.
Fabian.

Comment 6

[Jean-Francois Ducarroz]

Thanks for sending this patch. However, I have modified it as I don't want the
row to be deleted and in case you press enter on an empty field which is not the
last one, the cursor should go to the next address.

here is the function (sorry, no diff as cvs is temporary down):

function awReturnHit(inputElement)
{
	var row = awGetRowByInputElement(inputElement);
	var nextInput = awGetInputElement(row+1);

	if ( !nextInput )
  {
    if ( inputElement.value )
			awAppendNewRow(true);
    else // No adress entered, switch to Subject field
    {
		  var subjectField = document.getElementById( 'msgSubject' );
			subjectField.select();
		  subjectField.focus();
    }
  }
	else
  {
    nextInput.select();
		awSetFocus(row+1, nextInput);
  }
}

Comment 7

[David :Bienvenu]

sr=bienvenu

Comment 8

[(not reading, please use [e-mail] instead)]

r=sspitzer

Comment 9

[Jean-Francois Ducarroz]

Fixed and checked in. Thanks Fabian Guisset for helping with this bug.

Comment 10

[Fabian Guisset]

Thanks for being quick on this, as usual. :-)
Fabian.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

This is FIXED on all platforms, today's build 12-26-00