625255 - split nsHyperTextAccessible::GetChildOffset(PRUint32 aChildIndex, PRBool aInvalidateAfter) on getter and invalidator/getter

Status: NEW

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

spun off bug 625009 comment #2

Comment 1

[Hubert Figuiere [:hub]]

Still to do. Probably low priority.

Comment 2

[Hubert Figuiere [:hub]]

Attachment: Proposed patch

Here is my proposed patch.

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 571970 [details] [diff] [review]
Proposed patch

Review of attachment 571970 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHyperTextAccessible.cpp
@@ +2161,4 @@
>    return true;
>  }
>  
> +

Nitpick: needless newline.

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 571970 [details] [diff] [review]
Proposed patch

this doesn't fix the problem actually, you still have confusing methods. Maybe you could rename them into GetChildOffsetAndInvalidate(nsAccessible* aAcc, bool aDoInvalidate = true) and provide short versions like GetChildOffset. While you're here please consider to keep naming as ChildOffsetAt or ChildOffsetFor which is more reasonable in english.