627498 - GL disabled on OS X, Android due to not calling Init

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Joe Drew (not getting mail)]

Attachment: call Init in the constructor function on Android and Cocoa

I stupidly didn't make sure GfxInfo::Init was called on non-Windows platforms. This patch fixes that.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 505522 [details] [diff] [review]
call Init in the constructor function on Android and Cocoa

Test for ogl layers on 10.6 please

Comment 2

[Joe Drew (not getting mail)]

Attachment: test acceleration status

This is a mochitest that makes sure that acceleration status is what we think it is on Windows and OS X. It would have prevented this bug!

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 505553 [details] [diff] [review]
test acceleration status

>+  <title>Test for Bug 627498</title>

A better title

Comment 4

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/2736d8740c66 is the fix. The test is currently going through Try.

Comment 5

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/d92d9dd27d9b

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Jeff, this appears to detect if gl is enabled on windowsXP+, and if it isn't then it will fail.  I am not sure what the relationship is between direct2D/webgl/canvas- maybe they are the same or have similar traits when it comes to support.

I am testing running the windows 7 tests in the cloud.  For machines that have a graphics card, this test case (test_acceleration.html) passes, but for the ones that do not have a dedicated graphics card this test fails.

We are looking to run the webgl tests (in the 'gl' job) as well as reftests on higher end machines that have full graphics support.  Most likely, I could put this test in the 'gl' job- I just don't understand how this related to webgl.

Jeff, can you help me understand this more and determine if it makes sense to put this test case in the 'gl' job.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

This is testing whether we have layers acceleration and is unrelated to webgl. It should run on a machine that has a GPU, but I'm not sure which is the best job for it.