62754 - Regression: META charset ignored

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P1)

Description

[Tracy Walker [:tracy]]

seen on commercial builds:

windows 2000-12-13-06-Mtrunk
linux 2000-12-13-03-Mtrunk
mac 2000-12-13-04-Mtrunk

many language sets on these pages are viewing incorrectly with odd symbols and 
signs

Comment 1

[Tracy Walker [:tracy]]

note:  this is only with the utf8 unicode page, not the ncr, it works fine.

Comment 2

[nhottanscp]

cc to iqa

Comment 3

[Tracy Walker [:tracy]]

corrected URL....

also this seems to be fixed with a setting for character coding. (unicode) 
(utf8)

reducing severity.

Comment 4

[Teruko Kobayashi]

Yoying, please test this in the latest trunk build.

Comment 5

[Yuying Long]

Tested 12-13 Mtrunk build:
WinME(Japanese):  Can't auto-detect this page as UTF-8, it detected as shift-JIS.
Mac.: same result as WinME.
Linux:  Detected this page as Western 8859-1 when there is no UTF-8 in sub-menu
of Charactor coding.

However, as far as I changed to Unicode-UTF8, the page looks fine with all 3
Platfom unless those languages that I don't have language packages installed in
my machine.

Addition information:
I checked the different Netscape homepage.  All 3 platform detected simplify
Chinese as Big5 Traditional.  And for most European language will show correct
UI but in sub-menu of Charactor coding, will show either western-1252 or the
coding of previous page. Also if there is no language code in sub-menu of
Character coding menu which are match with the meta tags language setting of the
homepage, it always has problem to dtect, unless you add the language setting in
sub-menu and reload the page.

Comment 6

[Teruko Kobayashi]

Hotta-san, Netscape does not detect meta charset correctly. Please work with
Yuying to solve this problem.

Comment 7

[Yuying Long]

Atcually, I think the problem is when there is no language code setting other
than Western(iso-8859-1) in View > Charactor coding, sub-menu, netscape will not
pick-up the correct language code setting even the setting already in "meta-tags".

Comment 8

[nhottanscp]

Looks like META charset is not workin, cc to harishd and vidur, can this be
related to vidur's check in (I see many parser related changes)?

Comment 9

[nhottanscp]

Changed the summary and reassign to harishd.

Comment 10

[nhottanscp]

Adding intl keyword.
Harish, what is a status of this bug?

Comment 11

[harishd]

nhotta, I think (~99%) the problem is with nsPromiseFlatString. I didn't get the
time yesterday to completely go thro' it, since I's working on another smoke
test blocker. Will look into the problem today.

Comment 12

[harishd]

Okay, I have a tentative(!) patch.. Will post it soon.

Comment 13

[Jure Repinc (JLP)]

Adding myself to CC list

Using Mozilla 2000121520 on Windows 2000.
It's a very annoying bug. I always have to set Character Coding manually but
pages that I visit have <meta http-equiv="Content-Type" content="text/html;
charset=iso-8859-2"> tag included.

Comment 14

[harishd]

Attachment: Proposed patch v1.1

Comment 15

[vidur (gone)]

sr=vidur. The unused nsMetaCharsetObserver::Notify() methods should be eliminated.

Comment 16

[nhottanscp]

Filed a bug 63194 for unused nsMetaCharsetObserver::Notify().

Comment 17

[Frank Tang]

r=ftang go ahead

Comment 18

[nhottanscp]

Please check in ASAP.

Comment 19

[nhottanscp]

*** Bug 63460 has been marked as a duplicate of this bug. ***

Comment 20

[harishd]

Fix is in..

Comment 21

[Tracy Walker [:tracy]]

verified fixed on commercial builds

windows 2000-12-26-06-mtrunk
linux 2000-12-26-06-mtrunk
mac 2000-12-26-08-mtrunk

Comment 22

[Yuying Long]

Verified fixed on 12-26 Mtrunk build:
WinME: Problem with Korean and Simplify Chinese.
       Korean(http://home.netscape.com/ko/): can detect the page as EUC_KR but
doesn't display correctly at all.
       Simplify Chinese(http://home.netscape.com/zh/cn/): can detect the page as
GB2312 but many Chinese characters show "?".

However, Linux and Mac build work good.

Comment 23

[Yuying Long]

I have another bug 63769 for the problem that I found today.

Comment 24

[Jure Repinc (JLP)]

Using of META tag is correct now.

But After you view a page with META charset set and then going to a page wich
does not have META charset set (a lot of english/american sites) stil show that
the charset from previous page is used. At least it is shown in View -> Charset
Coding menu like it has not bin changed to Mozilla default coding.

Using Mozilla 2000122620

Comment 25

[Tom Mraz]

Hmmm this one should be reopened. Using build 2001010221 the META with charset
is still ignored if the meta tag is specified after script tag with src attribute.
See my attachments.

Comment 26

[Tom Mraz]

Attachment: Testcase with the meta after src (wrong behaviour)

Comment 27

[Tom Mraz]

Attachment: Testcase with meta before script tag (right behaviour)

Comment 28

[nhottanscp]

The problem mentioned by Tom Mraz also happens with NS6 RTM, so it's a different
problem. It might be related to bug 61462.

Comment 29

[timeless]

n4 has really wierd behavior for 21729.

Comment 30

[Tom Mraz]

Hmmm... it's probably the same problem as in bug 61462 - I'll report it there.