63195 - remove unused XIF code from htmlparser/src/

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There are a bunch of files related to XIF that I think are no longer be used
since the NOXIF branch landed.  In particular:

htmlparser/src/nsXIFDTD.{cpp,h}
htmlparser/src/nsXMLTokenizer.{cpp,h}

nsXIFDTD.h is included only in htmlparser/src/nsHTMLToTXTSinkStream.cpp (which
akkana says Daniel Bratell has patches to remove),
htmlparser/src/nsTextConverter (which seems to be an |if| statement that is
probably no longer needed), and widget/src/xpwidgets/nsXIFFormatConverter.cpp
(which seems similar).  nsXIFDTD.cpp seems to be the only file using
nsXMLTokenizer, which I presume is what was used to parse XML before expat was
hooked up.  So there's probably some code in nsTextConverter.cpp and
nsXIFFormatConvert.cpp that needs to be removed before these files can be
removed from the build.

Comment 1

[Akkana Peck]

Adding Daniel, too, since he's already removed a lot of unused code (in a patch
to another bug) and might want to know about this.

I agree that we should remove this unused code.  It would also be nice if we
renamed nsXIFFormatConverter, perhaps to something like
nsClipboardFormatConverter? since it has nothing to do with XIF.  Adding
pinkerton since he owns it and might have opinions on the best name for it.

Comment 2

[Mike Pinkerton (not reading bugmail)]

nsXIFFormatConverter is no longer built on any platform and should be cvs
removed. I noticed last week that bratell tried to make changes to it, then
backed them out. bratell? care to comment on why you were in that file?

Comment 3

[Daniel Bratell]

It was part of the dependent bug 62432 where I tried to remove 
nsHTMLToTXTSinkStream. It caused a mac build problem so I had to back it out. 
As I still haven't found anyone with a Mac who wants to help me update the mcp 
file, I've been unable to check it in. Maybe you can help me?

Comment 4

[Mike Pinkerton (not reading bugmail)]

i can be your mac buddy on this one, but not before 1/15/01. i'll be back in
town then.

Comment 5

[Mike Pinkerton (not reading bugmail)]

I've removed widget/src/xpwidgets/nsXIFFormatConverter.cpp/.h from the tree.

Comment 6

[anthonyd]

okay, so can I assign this bug to either of you, mike or daniel?

anthonyd

Comment 7

[anthonyd]

assigning this to pinkerton so he can close this after he helps bratell with his 
mac issues.

anthonyd

Comment 8

[Johnny Stenback (:jst)]

... and I just removed layout/base/nsXIFFormatConverter.[cpp|h] from the tree...

Comment 9

[Mike Pinkerton (not reading bugmail)]

bratell, what needs to be done here? is there a patch i can apply to test on mac?

Comment 10

[Daniel Bratell]

I don't know. The only code I am aware of (and I was involved in) was the code 
that will be removed by bug 62432. 

Comment 11

[Mike Pinkerton (not reading bugmail)]

checked in.

Comment 12

[bsharma]

updated qa contact.

Comment 13

[bsharma]

Marking it verified as per above developer comments.