Closed
Bug 63273
Opened 25 years ago
Closed 25 years ago
PR_Assert should be defined in optimized builds.
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.1.1
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
847 bytes,
patch
|
Details | Diff | Splinter Review |
PR_Assert is now only defined in debug builds.
This makes it impossible for people to replace
a debug build of NSPR by an optimized build
because PR_Assert will be unresolved.
PR_Assert should also be defined in optimized
builds so that debug and optimized builds export
the same interface.
|
Assignee | |
Comment 1•25 years ago
|
||
|
|
Assignee | |
Comment 2•25 years ago
|
||
The proposed fix pretty much restores the code
to what it was like before (in rev. 3.13).
Checked in the fix on the main trunk.
/cvsroot/mozilla/nsprpub/pr/src/io/prlog.c, revision 3.20
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.2
|
|
Assignee | |
Comment 3•25 years ago
|
||
Larry and I discussed and thought that PR_Assert should
be defined the same way in debug and optimized builds.
Originally PR_Assert was defined to do nothing in optimized
builds.
I checked in this change on the tip.
/cvsroot/mozilla/nsprpub/pr/src/io/prlog.c, revision 3.21
|
|
Assignee | |
Comment 4•25 years ago
|
||
I merged this patch onto the NSPRPUB_RELEASE_4_1_BRANCH.
/cvsroot/mozilla/nsprpub/pr/src/io/prlog.c, revision 3.19.2.1
Set target milestone 4.1.1.
Target Milestone: 4.2 → 4.1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•