Closed
Bug 63368
Opened 24 years ago
Closed 19 years ago
Add a new rule to the make system for unit testing
Categories
(Firefox Build System :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: dprice, Assigned: Biesinger)
References
Details
Attachments
(1 file, 2 obsolete files)
3.78 KB,
patch
|
cls
:
review+
benjamin
:
review+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
add a new rule to the make system on all platforms to run any unit tests. Call it all-tests
Reporter | ||
Comment 2•24 years ago
|
||
Reporter | ||
Comment 3•24 years ago
|
||
Reporter | ||
Comment 4•24 years ago
|
||
adding cls to the CC list. Chris will you review the two diffs I've attached to this defect? Thanks.
The linux patch looks fine except that you should also add the dummy all-tests: rule to nsprpub/Makefile for the classic nspr build. CC'ing leaf for the windows patch.
Reporter | ||
Updated•24 years ago
|
Target Milestone: --- → mozilla0.8
Comment 6•24 years ago
|
||
r=leaf for the windows changes, cc'ing larryh for the nspr makefile stuff.
Reporter | ||
Comment 7•24 years ago
|
||
per chofmann moving past mozilla 1.0
Target Milestone: mozilla0.8 → mozilla1.1
Sorry about the spam. An unset priority should be less than P5.
Priority: -- → P5
Updated•20 years ago
|
Product: Browser → Seamonkey
Assignee | ||
Comment 10•19 years ago
|
||
I used "make check" instead of all-tests in order to be compatible with the automake target for the same purpose.
Assignee: dprice → cbiesinger
Attachment #21029 -
Attachment is obsolete: true
Attachment #21030 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #192307 -
Flags: review?(cls)
Assignee | ||
Updated•19 years ago
|
Priority: P5 → P1
Product: Mozilla Application Suite → Core
Assignee | ||
Updated•19 years ago
|
Attachment #192307 -
Flags: review?(benjamin)
Assignee | ||
Updated•19 years ago
|
Target Milestone: Future → mozilla1.8beta4
Assignee | ||
Comment 11•19 years ago
|
||
this patch also removes the LD_LIBRARY_PATH setting from the necko unit test runner. that means people should use "make check" or run-mozilla.sh explicitly, for compat with platforms that don't use LD_LIBRARY_PATH (and aren't mac).
Updated•19 years ago
|
Attachment #192307 -
Flags: review?(benjamin) → review+
Attachment #192307 -
Flags: review?(cls) → review+
Assignee | ||
Comment 12•19 years ago
|
||
Comment on attachment 192307 [details] [diff] [review] add "make check" target this only adds a new makefile target to the build system, very low risk
Attachment #192307 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #192307 -
Flags: approval1.8b4? → approval1.8b4+
Assignee | ||
Comment 13•19 years ago
|
||
Checking in config/rules.mk; /cvsroot/mozilla/config/rules.mk,v <-- rules.mk new revision: 3.487; previous revision: 3.486 done Checking in netwerk/test/Makefile.in; /cvsroot/mozilla/netwerk/test/Makefile.in,v <-- Makefile.in new revision: 1.85; previous revision: 1.84 done Checking in netwerk/test/unit/test_all.sh; /cvsroot/mozilla/netwerk/test/unit/test_all.sh,v <-- test_all.sh new revision: 1.5; previous revision: 1.4 done Checking in xpcom/tests/Makefile.in; /cvsroot/mozilla/xpcom/tests/Makefile.in,v <-- Makefile.in new revision: 1.89; previous revision: 1.88 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•