63368 - Add a new rule to the make system for unit testing

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[dprice (gone)]

add a new rule to the make system on all platforms to run any unit tests.

Call it all-tests

Comment 1

[dprice (gone)]

part of unit testing, blocks 63228

Comment 2

[dprice (gone)]

Attachment: patch to add the rule to windows

Comment 3

[dprice (gone)]

Attachment: patch to add the rule to linux

Comment 4

[dprice (gone)]

adding cls to the CC list.

Chris will you review the two diffs I've attached to this defect?  Thanks.

Comment 5

[cls]

The linux patch looks fine except that you should also add the dummy all-tests:
rule to nsprpub/Makefile for the classic nspr build.  CC'ing leaf for the
windows patch.

Comment 6

[Daniel (Leaf) Nunes]

r=leaf for the windows changes, cc'ing larryh for the nspr makefile stuff.

Comment 7

[dprice (gone)]

per chofmann moving past mozilla 1.0

Comment 8

[cls]

Sorry about the spam. An unset priority should be less than P5.  

Comment 9

[Vedran Miletic]

retargeting

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: add "make check" target

I used "make check" instead of all-tests in order to be compatible with the
automake target for the same purpose.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

this patch also removes the LD_LIBRARY_PATH setting from the necko unit test
runner. that means people should use "make check" or run-mozilla.sh explicitly,
for compat with platforms that don't use LD_LIBRARY_PATH (and aren't mac).

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 192307 [details] [diff] [review]
add "make check" target

this only adds a new makefile target to the build system, very low risk

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.487; previous revision: 3.486
done
Checking in netwerk/test/Makefile.in;
/cvsroot/mozilla/netwerk/test/Makefile.in,v  <--  Makefile.in
new revision: 1.85; previous revision: 1.84
done
Checking in netwerk/test/unit/test_all.sh;
/cvsroot/mozilla/netwerk/test/unit/test_all.sh,v  <--  test_all.sh
new revision: 1.5; previous revision: 1.4
done
Checking in xpcom/tests/Makefile.in;
/cvsroot/mozilla/xpcom/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.89; previous revision: 1.88
done