63416 - allow INI components and sections to be listed out of order

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Sean Su]

The installer currently has a cumbersome way to adding new components to be
recognized and therefore installed.

When adding a new component, the user has to make sure that the section name for
the component in the config.ini file is in a sequential numbering order, ie:

  ...
  Component10
  Component11
  Component12
  ...

And in addition to this requirement, each Setup TypeX section need to contain
the components in a certain sequential order.

  [Setup Type0]
  C0=Component10
  C1=Component11
  C2=Component12
  ...

This makes it extremely *difficult* and *confusing* to verify a change from a
given patch (as was encountered many times in the RTM release process).  The
simplification is to remove the 1st requirement so that arbitrary component
section names can be used.  This will make it easier to define and add new
components to each of the [Setup TypeX] sections.

Comment 1

[Daniel Veditz [:dveditz]]

The equivalent is already done on Windows.

Comment 2

[Daniel Veditz [:dveditz]]

Moz 0.9 tasks

Comment 3

[Samir Gehani]

Over to Syd for installer bug triage

Comment 4

[Daniel Veditz [:dveditz]]

*** Bug 170170 has been marked as a duplicate of this bug. ***

Comment 5

[Andrew Schultz]

==> me

Comment 6

[Andrew Schultz]

Attachment: patch to remove sequential requirement

this patch removes the requirement for sequentially listed sections and keys as
initially reported.  the problem was that the parser was matching the first hit
for "Component1", which could be "Component10" if the components were listed
out of order.

this will not fix bug 170170, which would require much more substantial
changes.

Comment 7

[Andrew Schultz]

marking FIXED.  further overhaul of of INI parser will happen in bug 170170