63846 - input type=image doesn't submit form (PowerPC, Macintosh)

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

I'm sure there's a bug on this somewhere, but I couldn't find the exact one, so
I filed.

If you type text into any textarea and click on the submit button in the Search,
you can't perform any ACTION and nothing gets submitted.

This happens strictly on Mac, 2000122708.

Comment 1

[Johnny Stenback (:jst)]

I don't see this on win2k at all and I don't have a mac to test with,
reassigning to the default owner of form submission, who also happens to have a
mac to test on :-)

Comment 2

[Johnny Stenback (:jst)]

Hmm, this was supposed to go to pollmann, reassigning. (Rod, if you have a mac
feel free to take this back if you wanna look into it)

Comment 3

[J Luh]

Image submit buttons aren't working with 2000122805 Mac trunk build on Mac OS 9.0.4.

Example:

resource:///res/samples/test8.html

Click on raptor submit button. Should submit the form, but nothing happens.

Comment 4

[Patrick C. Beard]

I confirm this, in my current tip builds, image-based form
submission isn't working.

Comment 5

[J Luh]

The last nightly build where image submit buttons worked was 2000-12-22-12.
They don't work in 2000-12-26-08 Mac trunk builds and later builds up to and
including 2001-01-02-09.

Comment 6

[Mike Pinkerton (not reading bugmail)]

this blocks me from using the product.

Comment 7

[Bradley Hart]

*** Bug 64993 has been marked as a duplicate of this bug. ***

Comment 8

[hirata masakazu]

*** Bug 64127 has been marked as a duplicate of this bug. ***

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 65227 has been marked as a duplicate of this bug. ***

Comment 10

[greggyb]

I see the very same problem with the version Mozilla-0.7 that I built for my
ppc-linux box, so I don't think it's a Mac-only thing (unless it's a very
unlikely Mac-hardware-only thing).  I _don't_ see it in the standard i386-linux
version that I downloaded at home.

Comment 11

[Matt Brubeck (:mbrubeck)]

Actually, powerpc-only bugs are common. Usually they happen because of 

differences in the C/C++ implementation (e.g. char is unsigned by default; 

integer types are bigendian). These bugs would show up under MacOS and Linux on 

PPC hardware.

Comment 12

[Keyser Sose]

*** Bug 65306 has been marked as a duplicate of this bug. ***

Comment 13

[Keyser Sose]

*** Bug 64607 has been marked as a duplicate of this bug. ***

Comment 14

[Bradley Hart]

*** Bug 65339 has been marked as a duplicate of this bug. ***

Comment 15

[Doron Rosenberg (IBM)]

this bug has not been getting any attention, and is a valid smoketest blocker
(B.26).

Comment 16

[Doron Rosenberg (IBM)]

sorry, did not notice that this is for image submit buttons only, so not
technically a smoketest blocker.

Comment 17

[Moses Lei]

suggest change of summary to "Cannot use image button to submit form on PowerPC".

Comment 18

[Fabian Guisset]

Updating summary to contain more keywords cuz this is a bitch to find in the
queries.

Comment 19

[Fabian Guisset]

*** Bug 65495 has been marked as a duplicate of this bug. ***

Comment 20

[James Green]

According to http://bugzilla.mozilla.org/bug_status.html#severity and my
opinion, this is not a blocker. It meets "Major" category right on the nose
though. Anyone not agree?

Comment 21

[Asa Dotzler [:asa]]

removing smoketest keyword. not a smoketest blocker.  

Comment 22

[Bradley Hart]

I disagree, a blocker is defined as blocking development and/or testing. 

Although it probably does not block much development, it certainly blocks 

me from testing some aspects of Mozilla.

Comment 23

[J Luh]

I suggest adding the mostfreq keyword as this bug has many duplicates--all of
the above plus bug 64113.

Comment 24

[Matthias Versen [:Matti]]

*** Bug 65645 has been marked as a duplicate of this bug. ***

Comment 25

[[e-mail] (gone - use [e-mail] instead)]

jst - anyway you can take a whack at this or know someone who can?  I know 
Eric's on vacation.  This works fine on build 2000-12-22-12.  The next build 
available for mac was 12-26-09, and it's broken there.  I'll try to check bonsai 
for what broke this.

Comment 26

[[e-mail] (gone - use [e-mail] instead)]

Here's the link to bonsai for all the "responsible" checkins: 
http://mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&b
ranchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2
&date=explicit&mindate=12%2F22%2F2000&maxdate=12%2F26%2F00&cvsroot=%2Fcvsroot

Comment 27

[Johnny Stenback (:jst)]

stephend, this Eric is not on vacation (Eric Krock is on vacation) so IMO this
bug is in the hands of the right person, pollmann, let me know if you want me to
look at this one with you on your mac since I probably broke it in my huge
content code checkin.

Comment 28

[Boris Zbarsky [:bzbarsky]]

*** Bug 64113 has been marked as a duplicate of this bug. ***

Comment 29

[Boris Zbarsky [:bzbarsky]]

*** Bug 65723 has been marked as a duplicate of this bug. ***

Comment 30

[J Luh]

If this is a PPC-specific bug, maybe a LinuxPPC user could help find the
offending code checkin by identifying which Linux builds worked between Dec 22
and Dec 26.

Comment 31

[Michael Stearne]

input type=image works on the MacOS 2000122212 build.  The downloaded package
was
http://ftp.mozilla.org/pub/mozilla/nightly/2000-12-22-12-Mtrunk/MacMozillaInstaller.sea.bin

This build works on
http://ureg.netscape.com/iiop/UReg2/login/login?U2_LA=en&U2_BACK_FROM_CJ=true&U2_CS=iso-8859-1&U2_ENDURL=http://mailredirect.netscape.com/&U2_NEW_ENDURL=http://mailredirect.netscape.com/?nu=1&U2_EXITURL=http://home.netscape.com/&U2_SOURCE=Webmail
 (Netscape Webmail Login).

Comment 32

[Johnny Stenback (:jst)]

My guess is that there's some offending source code that the mac compiler
doesn't like here and produces different code than other compilers and that
causes the submit to fail. I doubt using gcc on LinuxPPC will reproduce this
problem, but I could, of course, be wrong.

Comment 33

[hirata masakazu]

input type=image
reportedly fails in NT and Linux if the image is not loaded and ALT text is
displayed (bug 65747).

Comment 34

[Ted Rust]

no one has mentioned that you CAN submit these problematic forms, as long as
they happens to have exactly one text entry field ... using RETURN from said
text entry field submits form as exepcted.

Comment 35

[greggyb]

I pulled out older versions and rebuilt for linuxppc, hoping to find when the
problem started, but I couldn't find a case where this bug didn't exist.  I
tried 22 Dec 2000 08:00 PST and 12 Dec 2000 08:00 PST and a couple in between.
So if this bug didn't exist in the 22 Dec build for Mac, then the linuxppc
version of the bug may be different.

Does anyone know of a time when this worked for linuxppc (or am I the only
person who's noticed this on linuxppc)?

Comment 36

[meiering]

It is truly unbelievable that this bug hasn't been fixed in almost a month...
and just when the browser is actually becoming useable on a daily basis.

Comment 37

[Bradley Hart]

Why don't we have a smoketest for this?

Comment 38

[kaldari]

This bug is the only thing preventing me from using Mozilla as my default 

browser. As long as this bug persists, I consider Mac Mozilla unusable.

Comment 39

[Michael Stearne]

Mozilla is my default browser, but I would like it to be my families default
browser also.  But it's hard to explain why they have to open another browser
(maybe non-Netscape) to log into Netscape WebMail.  Mozilla is great anyway,
keep up the good work.

Comment 40

[Asa Dotzler [:asa]]

There are enough "advocacy" comments in this bug.  Going forward can we please
keep comments focused on the technical problem itself, possible solutions, etc.
 We have a voting mechanism for advocacy that doesn't spam and doesn't cloud the
technical discussion that will hopefully lead to a fix.  This bug has all the
keywords it needs and it's assigned to the right person.  If you'd like to
discuss how this bug frustrates you, why it gives your grandmother migraines,
how it plays into world hunger, why it will be the downfall of AOL or whatever,
then take that to IRC please.  Thank you.

Comment 41

[Mike Pinkerton (not reading bugmail)]

bryner says he sees this on linux x86. it's not a ppc issue.

Comment 42

[Brian Ryner (not reading)]

Just to clarify, I am able to submit the form on netscape.com, but on
moviefone.com, if I type in my ZIP code and click on the "Go" image next to the
textfield, the form does not submit.

Comment 43

[greggyb]

I tried building a debug version of Mozilla-0.7 on my YellowDogLinux (ppc) box.
 I find that the bug goes away for me if optimization is turned off.  I'm using
the version of gcc that came with my Linux installation (gcc-2.95.2).  I just
noticed the new report of a problem with the moviefone.com site: that problem
still exists even with optimization off, but it could be a different version of
the bug since it involves javascript stuff.  (I think all the other references
to this bug are plain image submit buttons.)

Comment 44

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

movifone.com should be a separate bug.  (FWIW, the HTML there is bad enough that
it *shouldn't* work, and it's likely to be a parser bug.)  Other than that, this
is PPC-only, so changing back to mac only since that's the closest indicator
bugzilla has.

If you can submit the forms on http://www.netscape.com or on test8, then you
don't see *this* bug.

Comment 45

[Mike Pinkerton (not reading bugmail)]

in my 1/5 opt build from mozilla.org, this doesn't work. in my 1/19 tip debug
build, this works and I can't find any problems!

Maybe it's packaging? Maybe it's timing related?

Comment 46

[Mike Pinkerton (not reading bugmail)]

the 1/19 mozilla.org optimized bits show this problem, yet as i said before, my
debug build from later that afternoon doesn't.

Comment 47

[Mike Pinkerton (not reading bugmail)]

it's an uninitalized variable. here's the patch:

Index: mozilla/layout/html/forms/src/nsImageControlFrame.cpp
===================================================================
RCS file: /m/pub/mozilla/layout/html/forms/src/nsImageControlFrame.cpp,v
retrieving revision 3.59
diff -u -2 -r3.59 nsImageControlFrame.cpp
--- nsImageControlFrame.cpp	2001/01/04 20:44:17	3.59
+++ nsImageControlFrame.cpp	2001/01/22 08:31:33
@@ -443,5 +443,5 @@
     mFormFrame->GetContent(&formContent);
 
-    nsEventStatus status;
+    nsEventStatus status = nsEventStatus_eIgnore;
     nsEvent event;
     event.eventStructType = NS_EVENT;

Comment 48

[Mike Pinkerton (not reading bugmail)]

fixed. *whew*

Comment 49

[hirata masakazu]

Verified in 2001012204MTrunk. Great!

Comment 50

[Blake Ross]

*** Bug 66211 has been marked as a duplicate of this bug. ***

Comment 51

[Eric Pollmann]

Thanks Mike, you rock!  :) (Amazing Mac was the only one seeing problems...)