63913 - [RFE] Page info panes should be adjustable, have scrollbars

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, enhancement)

Description

[Eric Vaandering (no email)]

In the page info window it would be nice if the relative size of the panes was
adjustable (i.e. take vertical space from forms and give it to images).
Horizontal and vertical scrollbars are also needed for when the list of images
or forms is too big for the window.

Right now the only adjustment seems to be how much space is allowed for the
image preview.

I'd also argue that the default should be more like 1:2 or 1:3 forms:images
since most pages have many more images than forms, but this is a minor issue.

Comment 1

[Keyser Sose]

Added [RFE] marking NEW.

Comment 2

[timeless]

This should be easy, marking helpwanted and inviting hwaara to consider.

Comment 3

[Daniel Brooks [:db48x]]

I'll take it, if hwaara doesn't mind.

I'd like some clarification however. Ewv, when you say it needs scrollbars when
the list of images/forms gets long, do you mean horizontal, or vertical? I see
vertical ones when the list is long enough, so I'm not sure what you're asking
for there.

Comment 4

[Håkan Waara]

Daniel: sure, take it.

Comment 5

[Eric Vaandering (no email)]

You are right. The scroll bars are usually there. When I reported the bug. for
whatever reason they weren't showing up for the list I was looking at.

I'd say disregard for now and if I can reproduce this behavior again, I'll open
a new bug.

Comment 6

[Daniel Brooks [:db48x]]

Attachment: patch to pageInfo.xul, adds another splitter between the forms list and the images list

Comment 7

[Daniel Brooks [:db48x]]

Attachment: patches pageInfo.js to unhide the new splitter when needed

Comment 8

[Daniel Brooks [:db48x]]

I realize that these patches aren't quite in standard form, but it's the best I
can do until I get cvs working. (/me mumbles) They're both -wu, as I reformatted
patgeInfo.xul rather heavily. not much point in blaming me for the entire file.

Comment 9

[Daniel Brooks [:db48x]]

Attachment: Another way of modifying it, suggested by timeless.

Comment 10

[Daniel Brooks [:db48x]]

Attachment: modifications to the javascript portion of the window

Comment 11

[Daniel Brooks [:db48x]]

This revision is pretty cool. Timeless suggested it, and I think it's maybe
worth looking into. I don't think it's vastly better than the simpler version I
posted above. It's got a few bugs, and it'll probably never be bug free unless
xul trees are modified to allow varible height rows and stuff. Comes pretty
close though.

I'll fix the one or two little things that were wrong with my previous patch,
get it reviewed and commited tommorrow sometime. yay, sleep. maybe I'll get some
tonight.

Comment 12

[Daniel Brooks [:db48x]]

heh, actually, I was just thinking. Most of what that javascript does could be
done with CSS. In fact, probably all of it except for listing all the
forms/images are in the document. It really wouldn't suprise me at all.

Comment 13

[Daniel Brooks [:db48x]]

Attachment: original patch, with minor modifications per original review. Removed an extra box, allowing me to fufill the request that the forms list be smaller than the images list

Comment 14

[Daniel Brooks [:db48x]]

Attachment: second half (ugh) of the original patch, with bonus cleanup resulting from a change in the xul file (yay!)

Comment 15

[Marcia Knous [:marcia]]

Netscape nav triage team: per Alec Flett's pre-triage recommendation, this 
bug is nsbeta1-.

Comment 16

[timeless]

my style prefs [you may ignore]:
if (a) {
  b();
}
function a()
{
  b();
}
Not adding contributor comments [cvs blame is much better and doesn't bloat 
code]

Probably not to ignore is js/dom-id naming convention:
interCaps I think is the name.
so instead of formimagesplitter use formImageSplitter

Comment 17

[Daniel Brooks [:db48x]]

Attachment: removed spurious flex="0", renamed a few ids, kept the brace style of the existing code (well, mostly), took my name out of contributers list (doesn't bother me, whatever the convention is), probably other minor things that don't really affect much, etc.

Comment 18

[Daniel Brooks [:db48x]]

Attachment: see above

Comment 19

[Daniel Brooks [:db48x]]

Attachment: A single patch for both files (yay!) to fix a few little things jag pointed out. I think it's ready for sr= and have a module ower look at it :P

Comment 20

[Daniel Brooks [:db48x]]

Attachment: a few small style changes, removed some tabs from pageInfo.js, minor things

Comment 21

[Daniel Brooks [:db48x]]

Attachment: major style changes, as requested by timeless

Comment 22

[Daniel Brooks [:db48x]]

Attachment: doh, I broke it in the last patch. this one works though

Comment 23

[Daniel Brooks [:db48x]]

Attachment: more minor style fixes

Comment 24

[timeless]

r=timeless

Comment 25

[Blake Ross]

cc'ing alec for sr

Comment 26

[Alec Flett]

please don't arbitrarily change stuff like
if (foo.length == 0) to if (!foo.length)

== 0 makes sense in specific contexts and is easier to read when the number 0 is
actually signifigant.

Comment 27

[Daniel Brooks [:db48x]]

yea, I only did it at the request of a reviewer. I can make a new patch if needed.

Comment 28

[Alec Flett]

sorry you went through the extra work, the reviewer was making unnecessary
requests (timeless? :)).. if you could put it back, I'd really appreciate it.

Comment 29

[Daniel Brooks [:db48x]]

Attachment: Not a problem. Anything else?

Comment 30

[Alec Flett]

this is fine.
there are still a lot of unnecessary style changes. Please try to minimize style
changes in the future, limiting them only to places where readability is
actually impaired (yes, another subjective judgement, I know..)

Comment 31

[Daniel Brooks [:db48x]]

Attachment: diff -wu of last patch

Comment 32

[Alec Flett]

sr=alecf, thanks.

Comment 33

[Blake Ross]

checked in.

Comment 34

[sairuh (rarely reading bugmail)]

vrfy fixed on the 3 main platforms using comm branch bits, 2001.06.07.0x.