64054 - 'Recursive' warning for nsCRT.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David Gardiner]

MS C++ compiler v12.00.8804 gives the following warning when compiling 
nsCRT.cpp:

D:\mozilla_src\mozilla\xpcom\ds\nsCRT.cpp(571) : warning C4717: 'nsCRT::atoi' : 
recursive on all control paths, function will cause runtime stack overflow

Inserting :: before the atoi() makes the compile fail, as the argument for the 
system atoi() is not Unicode.

I've done a search in LXR, and my guess is that this nsCRT method isn't 
actually being used anywhere, which might explain why the compiler's prediction 
of doom doesn't seem to have become reality.

-dave

Comment 1

[David Gardiner]

This appears to have been fixed in bug 88747, which is actually a dup of this.

-dave