64362 - Show Me This Alert Next Time" should be "Show me this alert next time

Status: VERIFIED DUPLICATE of bug 44042

(SeaMonkey :: General, defect, P3)

Description

[Håkan Waara]

In the security warning I get, when I post something to a server as plaintext,
it says "Any information you submit is insecure...". At the bottom of this
dialog there's a checkbox, "Show Me This Alert Next Time.".

What I wanna do is to change this to "Show me this alert next time", 'cause
right now it looks rather silly.

Comment 1

[Håkan Waara]

Accepting.

Comment 2

[Peter "jag" Annema]

Here ya go, mpt.

Comment 3

[Matthew T (active 1999-2002)]

[--> Security: General component, since it's an obvious bug and someone has 
signed up to fix it.]

Comment 4

[Håkan Waara]

Attachment: Fixed all instances of "Show Me This.." I could find in LXR.

Comment 5

[Håkan Waara]

Attachment: Corrected three small errors in the patch per jag.

Comment 6

[Peter "jag" Annema]

r=jag

I'll check this in for hwaara.

Comment 7

[Matthew T (active 1999-2002)]

Provided that the checkbox is in a consistent position, the text should really be 
context-sensitive. If we say `next time', quite a few people will be wondering 
`next time what?'. (And if we say `show me this alert', the occasional person 
will wonder `what's an alert?'.)

So, I suggest the `Show this alert next time' string be split into three:
* Always alert me when I enter a secure area
* Always alert me when I leave a secure area
* Always alert me when I submit information insecurely

Also, DontShowAgain should be renamed to ShowAgain.

Comment 8

[Peter "jag" Annema]

mpt: So when I uncheck "Always alert me ...", does that mean it will not always
alert me? I like the more specific wording though. Someone want to implement
that?

Comment 9

[Matthew T (active 1999-2002)]

Yes, I guess `Always alert me when ...' could make some people imagine non-
existent steps of `Sometimes alert me when ...', `Occasionally alert me when 
...', `Alert me when it is a full moon and ...', etc. So perhaps `Alert me 
whenever ...' would be better.

Comment 10

[Peter "jag" Annema]

Ooooh! Can we implement the "Alert me when it is a full moon and ..." one?

Comment 11

[Håkan Waara]

Reassigning to component owner as I don't know how to implement the new idea.

Comment 12

[Mitchell Stoltz (not reading bugmail)]

The security warnings are owned by Security:Crypto (or maybe Networking?)

Comment 13

[John Unruh]

Reassigning

Comment 14

[David P. Drinan]

Mass changing of product. Browser:Security:Crypto --> PSM 2.0

Comment 15

[Matthew T (active 1999-2002)]

Reassigning after discussion with Håkan. `Show me this alert next time' sucks, 
but not as much as `Show Me This Alert Next Time' does -- so the change is 
worth it for now.

Comment 16

[Håkan Waara]

CC'ing a bunch of people. 

Ducarroz: Please review my tiny change in the compose code.

Bryner and Harishd who are (according to CVS blame) responsible for the netwerk/
wording and P3P coding I changed.

Patch coming up for you all...

Comment 17

[Håkan Waara]

Attachment: fix

Comment 18

[timeless]

-DontShowAgain=Show Me This Alert Next Time.
+DontShowAgain=Show me this alert next time
-ShowAgain                    = Show me this alert next time.
+ShowAgain                    = Show me this alert next time
-<!ENTITY dontshowagain.text     "Don't show me this alert next time.">
+<!ENTITY showagain.text         "Show me this alert next time">
-          currentIdentity.showSaveMsgDlg = !checkbox.value;
+          currentIdentity.showSaveMsgDlg = checkbox.value;
-CheckMsg=Do not show me this dialog box again.
+CheckMsg=Show me this alert next time

Ok, so we have 4-5 names for one silly string (yuck), and you renamed _one_ of 
them, but I hope it's unused, because I don't see a corresponding rename in 
.xul or .cpp or .h

I like CheckMsg over *ShowAgain but that's just me.

Comment 19

[Håkan Waara]

Yeah, that string was unused. Can I get r= on this?

Comment 20

[Håkan Waara]

future. :/

Comment 21

[Gervase Markham [:gerv]]

This is being made context-sensitive over in bug 44042.

Gerv

*** This bug has been marked as a duplicate of 44042 ***

Comment 22

[timeless]

.