64445 - 0[91d5eb0]: ###!!! ASSERTION: nsScriptNameSetRegistry not thread-safe: 'owningTh

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs to WebShell, defect)

Comment 1

[edburns]

Posted to n.p.m.embedding:

Your message has been submitted to netscape.public.mozilla.embedding. 

NOTE: If you made a mistake and need to cancel your message, you can cancel it 
from our cancel page.
To do so you will need this Message-ID: <935mes$fr3$[e-mail]>. 

Comment 2

[edburns]

The reason for the assertion is that Preferences doesn't use ActionEvents.

I'm about to attach a checkpoint of the conversion of Prefs to actionEvents.

Comment 3

[edburns]

Attachment: tar.gz checkpoint.

Comment 4

[edburns]

Attachment: tar.gz of fix for this bug, first iteration.

Comment 5

[Ashu Kulkarni]

Comments about Patch -
* Makefile.win and Makefile.in - ok
* PreferenceImpl.cpp -
  you have code like - goto NSUP_CLEANUP everywhere in this file.
  Instead of goto, you could define a macro for doing the cleanup + return
  from function. Then you can just call that macro eveywhere instead of
  using goto.  
* PreferenceActionEvents.cpp - same problem. goto should be avoided wherever
  possible.
* PreferenceActionEvents.h - ok

pls let me know if you agree with these comments. 
_Ashu

Comment 6

[edburns]

Ashu, I prefer to have a single return in each method, more so than a simple 
local goto.  In any case, this goto logic is used all over the code.  If we're 
going to change that strategy, we should do it everywhere.  Given that, can I 
please have r=?

Thanks,

Ed

Comment 7

[Ashu Kulkarni]

r=ashuk

Comment 8

[edburns]

Fix checked in.

Comment 9

[Vladimir Strigun]

Verified with mozilla branch NETSCAPE_6_2_RELEASE and blackwood sources from 
trunk. Preferences works fine, I cannot see any assertions.
Changed QAContact and add myself to cc list.