64489 - Esc should dismiss Page Info dialog

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, enhancement)

Description

[Jesse Ruderman]

1. Ctrl+I to bring up page info dialog.
2. Escape.

Page Info should close, but it doesn't.  (Alt+F4 works.)

Comment 1

[Martin Horwath]

amm...

is this a enhancement request ? this also doesn't work with ns4.x on win98...
does any open window in mozilla anything when pressing 'ESC' ?

Comment 2

[Jure Repinc (JLP)]

Would be great and it is an enhancement request.
BTW: Find in this page dialog closes on ESC.

Comment 3

[timeless]

This should not be done. Page Info is a _window_ it is not a _dialog_.

Dialogs have escape to close, windows don't.

Recommend wontfix. cc ben.

Comment 4

[Matthew T (active 1999-2002)]

Does Ctrl+W work, as well as Alt+F4?

Comment 5

[timeless]

indeed it does, just like nc4

Comment 6

[sairuh (rarely reading bugmail)]

agree with timeless. marking wontfix since this is a window, not a dialog [and
that ctrl+w works fine].

Comment 7

[Matthew T (active 1999-2002)]

Verified wontfix.

Comment 8

[Jesse Ruderman]

Users often *treat* the Page Info window as a dialog, and esc isn't harmful 
(just re-open the dialog), so I take it the only reason we don't support escape 
in this window is to be consistent with the "window" vs "dialog" distinction.  
Consistency with the user's expectation of escape closing Page Info *might* be 
more important here.

Note that I didn't figure out it was a window as soon as I noticed Esc didn't 
work, so that didn't help me realize that I could click outside of the window 
to re-focus the page.  I only found that out when Timeless pointed out that 
Page Info was a window.

Comment 9

[Jesse Ruderman]

Fwiw, the new page info dialog does go away when you hit escape.  If anyone 
files a new bug on that, please cross-reference it with this bug.  (I like that 
behavior and so I don't plan to file a bug about it.)

Comment 10

[Jonas Jørgensen]

Any chance this could be reopened and fixed? Page Info might be a window from
the programmer's point of view, but from the user's it's a dialog. I think most
users expect Esc to close any window that they open to perform some task other
than their primary task. That would make Navigator, Mailnews and ChatZilla
windows but Page Info and Bookmarks (and perhaps View Source as well?) dialogs.

As Jesse said, »the only reason we don't support escape in this window is to be
consistent with the "window" vs "dialog" distinction. Consistency with the
user's expectation of escape closing Page Info *might* be more important here«.
IMO, it's *definitely* more important. The application's job is to do what the
user expects.

Comment 11

[Alec Flett]

well, I don't know. if someone wants to take this bug and fix it I don't care.
This was assigned to me back when I worked on this stuff :)

Comment 12

[Jonas Jørgensen]

Attachment: proposed patch

If it gets decided that this bug should be fixed after all, this patch should
do it.

Comment 13

[Jonas Jørgensen]

Attachment: I attached the wrong file - duh!

Comment 14

[Alec Flett]

I don't want to debate this :)

Comment 15

[Alec Flett]

over to timeless :)

Comment 16

[timeless]

gee, thanks alec :)

Comment 17

[timeless]

i'm going to stand by my verified wontfix.
[e-mail] Status       NEW   RESOLVED   2001-01-08 12:29:55
[e-mail] Resolution         WONTFIX    2001-01-08 12:29:55

Comment 18

[timeless]

[e-mail]  Status   RESOLVED  VERIFIED   2001-01-08 18:57:26

Comment 19

[Jesse Ruderman]

Does anyone have a better reason for wontfix than "this is a window, not a 
dialog"?  Also, if most users think it's a dialog, what makes it a window?

Comment 20

[timeless]

resizability (min, max, size). the lack of a what's this widget.

Comment 21

[Dave Miller [:justdave]]

The ESC key is not for closing windows (or dialogs for that matter).  The ESC
key is the standard keyboard shortcut for the CANCEL button.  Most dialog boxes
have a CANCEL button on them.  Thus ESC works to close them because hitting ESC
is the same as clicking the Cancel button.  So the way to answer this question
is to look on the Page Info window/dialog/whatever and see if it has a cancel
button on it.  If it doesn't, then ESC shouldn't do anything.

Comment 22

[Daniel Brooks [:db48x]]

Comment on attachment 66549 [details] [diff] [review]
I attached the wrong file - duh!

r=db48x

I don't care whether it's a dialog or a window, the patch is useful, and it
works.

Comment 23

[Jonas Jørgensen]

Alec: I know you don't care about this bug, but now that the patch has r= from
the component owner, I have to ask _someone_ for sr= :) could you sr= it, please?

Comment 24

[Alec Flett]

Comment on attachment 66549 [details] [diff] [review]
I attached the wrong file - duh!

sr=alecf

Comment 25

[Jonas Jørgensen]

db48x, could you check this in for me please? I don't have a CVS account.

Comment 26

[Asa Dotzler [:asa]]

Comment on attachment 66549 [details] [diff] [review]
I attached the wrong file - duh!

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 27

[Daniel Brooks [:db48x]]

/me wishes
I'd don't have a CVS accout either. alecf, you've checked things in for me
before, could you check this one in as well? you did sr= it...

Comment 28

[Alec Flett]

done.

Comment 29

[Patty Mac]

Verified on all platforms (netscape trunk build: 2002-12-04-08-TRUNK)