Closed Bug 64932 Opened 25 years ago Closed 24 years ago

www.mozilla.org page wrapper needs to be standards-compliant

Categories

(mozilla.org :: Miscellaneous, task)

Product:
mozilla.org
Component:
Miscellaneous
Platform:
x86
Windows 95
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: gerv, Assigned: endico)

References

(
URL
)

Details

Attachments

(6 files)

Patch for template.html
3.01 KB, patch
Details | Diff | Splinter Review
Patch for wrap.pl
3.98 KB, patch
Details | Diff | Splinter Review
New CSS file for persistent styles
626 bytes, text/css
Details
patch, version 2
7.18 KB, patch
Details | Diff | Splinter Review
Dawn's moz site with patch in NS 3.04
44.02 KB, image/gif
Details
New 3.04 screenshot of /index.html
38.24 KB, image/gif
Details
As part of the short-term updates to make www.mozilla.org better, more shiny, and more representative of the One True Way, we want to make the wrapper compliant with HTML 4.01. Then, all the pages that are valid HTML 4.01 without the wrapper will still be valid with the wrapper :-) After this is done, we can go through validating major www.mozilla.org pages, in the knowledge that it's not the wrapper that's breaking stuff. Henri Sivonen has kindly done the rewrite - if he could post the latest versions of his patches here, we could see about checking them in. I've tested them by applying them to my local tree and running the site builder script - it works fine, until my Perl barfs on the 8MB "ns6analysis.html" file somewhere in the site. Gerv
Keywords: patch
Dawn - could you possibly take a look at this? Thanks :-) This is a short-term measure, independent of the redesign, to improve mozilla.org's standards-conformance. Gerv
i'm finally going to review this. expect to see it appear on http://dsl081-068-125-sfo1.dsl-isp.net/mozilla/
Status: NEW → ASSIGNED
there were some problems with the original patch because it used the absolute url at www.mozilla.org for the css file. Changed the script so it now uses a relative url and fixed same type of problem that already existed in the wide layout. Also, the script was creating two <head> sections for files that already had a head section and the <link> tag was outside of the head section. between the head and body sections. Attaching the new patch and the patched version is running at http://dsl081-068-125-sfo1.dsl-isp.net/mozilla/ I'm interested in seeing what this looks like in 3.x browsers. I havent' noticed any problems with 4.61 or mozilla. (on linux)
URL: None → http://dsl081-068-125-sfo1.dsl-isp.ne...
Attached patch patch, version 2 — — Splinter Review
http://dsl081-068-125-sfo1.dsl-isp.net/mozilla/docs/end-user/ validates as <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"> To make it work, i had to add a doctype to the file and delete "align=center" from an H1 tag.
checked in persistent-style.css
Very good, in fact. Attaching a GIF screenshot of Nav 3.04. Gerv
gerv's image cheated a bit. first, he had a pref set to make backgrounds white. Second, at the point he did the screenshot, only the menubar had been css-ized. Last night I changed the home page to use css and removed <td BGCOLOR. It doesn't quite validate yet but I believe that now in 3.x the boxes will disappear and the whole page will be gray. That's yucky, but I guess the page is still pretty legible. I just updated template-nomenu.html to use css. I've added the html4 strict doctype to docs/index.html and docs/end-user/ and both of these pages validate showing that the wrappers work. I also cleaned up /index.html but it doesn't yet validate. Here are the urls with the 4.x doctype http://dsl081-068-125-sfo1.dsl-isp.net/mozilla/ http://dsl081-068-125-sfo1.dsl-isp.net/mozilla/docs/ http://dsl081-068-125-sfo1.dsl-isp.net/mozilla/docs/end-user/
Well, white is the default on Windows. If it's grey on other platforms, that just means that it's Netscape's mistake when making the Nav 3 packages ;-) It still looks pretty good. New screenshot attached. Gerv
i'd also like to note that the banner image isnt' quite right. In Netscape 4, the botom border is quite large. In mozilla, there is an extra pixel wide border on the top and bottom of the banner image. I believe this is due to the anchor. Everything there is sprinkled liberally with border:0's so i'm not sure what's going on. I may just be having a cache problem though. Just now I looked at one url and the border looked correct. Then i went to another page and the border was wrong. Then i went back to the first page and the border there was wrong again. View the image alone to see what the border should actually look like. If there's really something wrong here and there's an easy fix, then lets fix it. I guess i wont worry about it too much though since I want to switch to another image anyway.
It all looks fine to me; in NS 4.x there's more whitespace all around the banner, but it doesn't really make any difference to the look. I think we've got it :-) Gerv
Dawn - is the latest version of this wrapper going to make it onto www.mozilla.org? I know we have plans for other things, but this is a good short-term fix to make. Gerv
fix checked in as well as changes to docs/index.html and docs/end-user/index.html to make them validate as html 4.01 strict. Also, fixed some of the html prooblems on /index.html and /news.html
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
v
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: