65273 - Necko needs to have a shutdown for protocol handlers

Status: RESOLVED INACTIVE

(Core :: Networking, defect, P5)

Description

[Doug Turner (:dougt)]

Necko needs to better manage the protocol handlers.  It should allow protocol
handlers to register with the IOService.  Upon shutdown, the IOService should
warn the protocol handlers that they should clean up (eg. cancel any outstanding
connections).  

Necko's IOService should also hold on to the eventQueue service so that the
handlers can post messages while they shutdown.

Currently the IOService hold WeakReferences to all the handlers.  

Because of this lack of shutdown functionality, the nsFTPProtocolHandler needs
to hold an unused reference to the IOService so that it can ensure its exists
when shutdown occurs.

Comment 1

[Darin Fisher]

I agree.. this really needs to be cleaned up.

Comment 2

[benc]

mass move, v2.
qa to me.

Comment 3

[Simon Fraser [no longer active]]

This bug is causing a crash on shutdown on Mac, after visiting an FTP site, 
because FTP attempts to disconnect the control connection after the 
nsSocketTransportService has been shut down. This causes the STS to attempt to 
set a pollable event for the socket transport thread after it has been joined.

We had to add a hacky workaround in Mac's NSPR code for now.

Comment 4

[Doug Turner (:dougt)]

no way this is going to happen in the 0.9.3 milestone.  

Comment 5

[benc]

Simon: can I get the bug number of the Mac patch?

Comment 6

[Simon Fraser [no longer active]]

The Mac NSPR workaround for this bug is in attachment 36178 [details] [diff] [review], on bug 69285. These 
lines:
+    if (pollDesc->pollingThread->state == _PR_DEAD_STATE)
+      return PR_FAILURE;
should be unnecessary.

Comment 7

[benc]

Thanks! That was the bug I was concerned was dependent on this problem...

Comment 8

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 9

[Doug Turner (:dougt)]

moving neeti's futured bugs for triaging.

Comment 10

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 11

[Valentin Gosu [:valentin] (he/him)]

I don't think this is a problem anymore.
The FTP protocol handler is gone, and Nika did a big refactoring of existing protocol handlers in bug 1793463.