66256 - both form manager dialogs have the same title

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[sairuh (rarely reading bugmail)]

not sure if this is a dup --couldn't find one like this after a couple of
queries. noticed this with a recent [this afternoon] linux debug build, but
might be cross-platform...

anyhow, to observe this:

1. select Tasks > P & S > Form Mgr > View Stored Form Data. result: a dialog
titled Form Manager appears. [looks like the preferences dialog, but you can
edit form data here. it's also modal --which is, um, odd on linux. is that
expected? already known?]

2. select Tasks > P & S > Form Mgr > View Sites. result: a dialog titled Form
Manager appears.

expected: i understand that both of these, while seperate tasks, together
comprise features of the form manager... but, afaik, shouldn't that have unique
titles? eg, "Form Manager: Editor" for (1) and mebbe "Form Manager: Sites" for (2)?

Comment 1

[Matthew T (active 1999-2002)]

This bug is mutually exclusive with bug 50495.

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

dveditz is the new module owner, reassigning.

Comment 3

[Andreas Kunz]

Now the "mutually exclusive" other bug is WONTFIXEd, so why not fix this one...

Comment 4

[Andreas Kunz]

Attachment: patch

I thought for a while, but chose the labels proposed in the bug description.

Comment 5

[Andreas Kunz]

Comment on attachment 139708 [details] [diff] [review]
patch

Requesting r= from mvl. This is not XUL, so I guess it's ok - and you are one
of this area's persons...

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 139708 [details] [diff] [review]
patch

r=mvl

Comment 7

[Andreas Kunz]

Comment on attachment 139708 [details] [diff] [review]
patch

Requesting r= from alecf.

In case you care about the poor translators again, I'm not sure what the
problem is: they don't _have_ to change anything, if they do, the change is
trivial, and it's no l10n freeze now, so...
However, I also don't care if this is WONTFIXed. I only want to see this bug
closed. But it was filed and not WONTFIXed until now, so...

Comment 8

[Alec Flett]

Comment on attachment 139708 [details] [diff] [review]
patch

sr=alecf

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in extensions/wallet/editor/resources/locale/en-US/WalletViewer.dtd;
/cvsroot/mozilla/extensions/wallet/editor/resources/locale/en-US/WalletViewer.dtd,v
 <--  WalletViewer.dtd
new revision: 1.6; previous revision: 1.5
done
Checking in extensions/wallet/signonviewer/resources/locale/en-US/SignonViewer.dtd;
/cvsroot/mozilla/extensions/wallet/signonviewer/resources/locale/en-US/SignonViewer.dtd,v
 <--  SignonViewer.dtd
new revision: 1.4; previous revision: 1.3
done

Comment 10

[Andreas Kunz]

v