666869 - Crash [@ nsGlobalWindow::GetPerformance]

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Simple fix

Comment 3

[Igor Bazarny]

Attachment: Simple fix with test

Thanks for report and fix. Here's the same fix with added mochitest

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to comment #3)
> Created attachment 541663 [details] [diff] [review] [review]
> Simple fix with test
> 
> Thanks for report and fix. Here's the same fix with added mochitest

You don't need a mochitest. I was planning to attach Jesse's testcase as a crashtest.

Comment 5

[Mounir Lamouri (:mounir)]

(In reply to comment #4)
> You don't need a mochitest. I was planning to attach Jesse's testcase as a
> crashtest.

By attach I mean push.

Comment 6

[Jesse Ruderman]

OTOH, maybe it's good to have it as a mochitest for the

  ok(frameWin.performance==null, 'Performance for non-existing frame???');

Comment 7

[Mounir Lamouri (:mounir)]

Pushed to mozilla-inbound with the crashtest.

Igor, can you write a patch that adds the test mentioned in comment 6 to the current performance test suite?

Comment 8

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/070f95edc105

Comment 9

[Igor Bazarny]

Attachment: Mochitest only

I had this test as part of the previous patch. There is not much of test suite yet, and the existing test covers basic scenario, so mixing this test in doesn't feel right to me.

Comment 10

[Ioana (away)]

Verified fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

I loaded the test case from the description on the above builds and none of them crashed. There were no other issues either.