66857 - disabling javascript still loads javascript into cache.

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[HJ]

If you disable Javascript, then all external javascript are still loaded and put
into disk cache You may check this behaviour with about:cache, or with an
protocol analyzer, as I did. Can't external Javascripts being blocked with the
help of HTTP filtering. If you don't like Javascript to run for a site, why
should web-surfers still load those files, if they don't want to use them?

Used the correct Severity, for the first time ever, thanks Hakan!

Comment 1

[Keyser Sose]

Marking NEW.

Comment 2

[neeti]

Cache bugs to Gordon

Comment 3

[gordon]

This is really up to http or its clients.

Comment 4

[Andreas M. "Clarence" Schneider]

*** Bug 80580 has been marked as a duplicate of this bug. ***

Comment 5

[jsp]

Any chance this will be addressed?  For what it's worth, IE 6 doesn't load
scripts if scripting is disabled.  This is obviously more of an issue where
bandwidth is limited.

I used a different (and for me, simpler) approach to determining whether the
browser was requesting the script files: I looked in the server log.

A workaround: load scripts dynamically, using something like the following:

  <script language="javascript" type="text/javascript">
    document.write('<script language="javascript" src="path/script.js"
type="text/javascript"> <\/script>');
  </script>

It's a little scary, but it works on IE 5+, Mozilla 1.4, and Opera 7.11.  (I
haven't tried earlier versions of Mozilla and Opera.)

Comment 6

[jsp]

The workaround mentioned above also works with Mozilla 1.0, 1.1, 1.2.1, and 1.3.

Comment 7

[Boris Zbarsky [:bzbarsky]]

It would be trivial to do a IsScriptEnabled check in the <script> node before
attempting to execute or load scripts... so just change:

648   if (mIsEvaluated || mEvaluating || !mDocument || !mParent) {
649     return;
650   }

To:


648 if (mIsEvaluated || mEvaluating || !mDocument || !mParent ||
!mDocument->IsScriptEnabled()) {
649     return;
650   }

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

r=sicking on that :)

Comment 9

[Johnny Stenback (:jst)]

sr=jst

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch to that effect

Comment 11

[Boris Zbarsky [:bzbarsky]]

Patch checked in.

Comment 12

[Andrew Schultz]

*** Bug 219322 has been marked as a duplicate of this bug. ***