66886 - Make PSM dialogs use correct nsIPrompt

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Brian Ryner (not reading)]

PSM dialogs need to use the nsIPrompt from the associated channel so that they
are correctly parented.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch to fix pipnss and some dialogs in psm-glue

Comment 2

[Brian Ryner (not reading)]

The patch I just attached adds a reference from the nsIChannelSecurityInfo
object to the channel that created it, as we discussed.  We then pass this to
the UI callbacks.

Can you both give this an r=?  Thanks.

Comment 3

[Javier Delgadillo]

adding thayes to cc list since he's interested in this topic.

Comment 4

[Javier Delgadillo]

Waiting on a new patch from bryner since his patch appears to be against an older 
version of pipnss.

Comment 5

[Brian Ryner (not reading)]

Attachment: updated patch for pipnss, also changes SSL_Enable to SSL_OptionSet

Comment 6

[Javier Delgadillo]

I don't know enough about the internals of getting the nsIPrompt, so I ask that 

danm review the code that gets the nsIPrompt from within the nssNSSSocketInfo.



For everything else r=javi

Comment 7

[Dan M]

The nsIPrompt code looks good. Well, except(!) a couple of things. Are you sure 
you need both proxied objects? All you're doing with proxiedCallbacks is QIing it 
to an nsIPrompt. I'm pretty sure it doesn't gain you anything to run that through 
the proxy machine. (whereas proxyprompt, of course, seems useful.)

The other thing is, sadly, at this point, callbacks may not successfully QI to 
nsIPrompt at all. There are still a couple of renegade places that send something 
else for the NotificationCallbacks. This is dealt with in places like 
nsWalletService.cpp (rev 1.48, line 600). I'm not actually recommending you copy 
that code, which falls back on Hidden Window. In theory, and we're working on 
this, the day will come when the fallback won't be necessary. For now the bad 
situation occurs only rarely if at all, but you should at least put in a warning 
or assertion.

Comment 8

[Brian Ryner (not reading)]

I wasn't planning to proxy the call to GetInterface, but I got threadsafety
assertions when I didn't.  If that means there's a problem somewhere else, maybe
we should track that down.

New patch to make sure proxyPrompt is non-null coming up.

Comment 9

[Brian Ryner (not reading)]

Attachment: new patch

Comment 10

[Dan M]

Heh. Sigh. Well, I guess extra proxies won't hurt. r=me on the nsIPrompt stuff.

Comment 11

[Scott MacGregor]

Looks good to me.
In the call to promptForPassword can you change the following:
 NS_ConvertASCIItoUCS2(" ").GetUnicode()
to use NS_LITERAL_STRING?

other than that,sr=mscott

Comment 12

[Brian Ryner (not reading)]

This was checked in, forgot to mark the bug fixed.

Comment 13

[Tom Everingham]

verified