66896 - Text zooming doesn't persist correctly when linked to by target="_top"

Status: NEW

(Core :: Layout, defect)

Description

[Aidas Kasparas]

Problem is the size of fonts used. Even if I have made this window use smaller 
or bigger fonts aftere change via link, containing target="_top" the window is
rendered in default font. But further font size changes are relative to that I
selected before following link.

Detailed scenario at URL given.

This affects all sidebar apps that go frough my.netscape.com

Comment 1

[Jure Repinc (JLP)]

I can reproduce the bug.
Mozilla 2001012820 on Windows 2000 SP1 on PC.
I think Platform/OS should be All/All.

Comment 2

[Christian Mattar]

Confirming;
Updating Summary;
Assigning to XPToolkit, although I bet it doesn't belong there.

Comment 3

[John Morrison]

Nice demonstration in http://www.lifosa.com/~kaspar/framebug. But, no, this 
isn't a xpwidget issue. Giving to erik who wrote the back end for text zoom, 
and cc: jag, who did the front end. 

Comment 4

[Peter "jag" Annema]

Hmmm... This is the back-end. It sounds like the actual zoom value is stored,
just not applied when loading a page with target="_top".

Comment 5

[Frank Tang]

Can you put down a test procedure, expect result and actual result. 

Comment 6

[Aidas Kasparas]

I tought the demonstration was suffitient. But if you insist:

1) open page containing link with target="_top" parameter;
2) pres Ctrl-'-' couple times;
3) follow link
TEST-1
4) you see new page rendered in the "standard"/"initial" font size;
5) you should see new page rendered in size you selected by pressing Ctrl-'-'
key combination.
[The same should work with Ctrl-'+' also]
TEST-2
6) press Ctrl-'-' again
7) you should see the page rendered in font which is smaller by
_one_and_only_one_ size position in comparison with what was displayed before
key combination was pressed.
8) at present it is smaller by one size position in comparison to the size that
was achieved in step (2)
[I suppose TEST-2 problem would disapear if TEST-1 problem would be solved, but
adding that to prevent regresions]

Comment 7

[Aidas Kasparas]

Attachment: copy of directory with demonstration. Start page index.html

Comment 8

[Aidas Kasparas]

Attachment: copy of directory with demonstration. Start page index.html

Comment 9

[Aidas Kasparas]

Attachment: copy of directory with demonstration. Start page index.html

Comment 10

[Aidas Kasparas]

Attachment: copy of directory with demonstration. Start page index.html

Comment 11

[Aidas Kasparas]

Attachment: copy of directory with demonstration. Start page index.html

Comment 12

[Aidas Kasparas]

Attachment: copy of directory with demonstration. Start page index.html

Comment 13

[Aidas Kasparas]

OOps, mozilla reported errors all the times I tried to ypload :-/

Comment 14

[Frank Tang]

erik resign. reassign all his bug to ftang for now.

Comment 15

[Frank Tang]

mark all future new as assigned after move from erik to ftang

Comment 16

[Jesse Ruderman]

See also:
bug 65571 changed text size resets to 100% between browser sessions 
bug 65156 text size reset to 100% after changing theme

Making text zoom a global pref rather than a per-window or per-document setting 
would fix all 3 bugs.

Comment 17

[deneen]

I agree with making it a global setting.

It's silly to set your text zoom while visiting a site, only to have it get lost
if that site opens a new window with javascript.  (I don't think it is just _top)

Comment 18

[Hansoo Kim]

>>  Making text zoom a global pref rather than a per-window or per-document 
>> setting would fix all 3 bugs.

If we must have a global preference controlling the Zoom foctor,
we should have both glocal and per-window and per-document ssettings.

The way I see is that the global preference would be used when
the window is being opened without any parent, for example, the first window.

Any windows opened by parent ( either by java script and/or taget attributes ) 
should inherite the tezt zoom factor from its parent, not from global settings.

The parent here should be considered as the structural parent ( where there is 
obvious relationship b/w parent and child windows, e.g. JavaScript, 
target="_blank". ), and also
navigational parent ( where the parent is defined as the triggering 
window/frame to change the target in question. ).

Consider the situation like this...

1) When we have a global setting only
A user goes to site A which uses a fairly small font sizes for its contents.
So the user had to increase ZOOM factor in global setting by preference dialog 
box or by using short cuts, which I assume now are bound to global setting, 
since no more per-window and per-doc setting.
After for a while the user realizes that s/he had worse vision than before and 
decided to purchase a new pair of glasses. S/he wanted to choose the frame over 
the net. The user goes to www.acne_frames.com and that site is using VERY BIG 
font size already for its potential customers, which makes most of the content
pushed out of the viewable area. The user has to change the setting again to 
see this site.  Now.... what happens to the windows viewing site A ?
Does it get refreshed with new setting, making our user to change the setting 
again to view the content of it again later ?

2) When we have only per-window and per-doc...
We already know there are some demands reported.
Obvious problems.

3) When we have both !!!
This is the best setting...
Let's apply this to the situation stated in (1)...

We have to change the asuumption stated in (1) a little bit.
A) We have global setting, which will only get applied to new window without 
any parent.
B) Changing gloabl setting only affects on any NEW windows which will get made 
after the setting change.  --> other words, not refresh for existing windows.
C) Changing the font size by control + "+/-" and/or Text Zoom menu only changes 
per-window/per-doc setting, NOT the global setting.
Now follow the situation again...
Now the user does not have to change global setting and always can go back to
another window which is viewed with its OWN comfortable zoom setting.


This is important....
Some embeddors, including myself, have some implementation under the assumption 
text zoom is per-window and per-doc only.
Plus, I think it makes more sense we have both of them.


How the parent ZOOM should be used for target frame/window...
Not sure of all the rules... so let's discuss about this.
But one thing I am sure is that target="_blank", should definitely inherite 
from the parent.

Thanks

Comment 19

[Adam Hauner]

-> to default owner