Closed Bug 67248 Opened 24 years ago Closed 24 years ago

Port libxpnet to the Mac

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P1)

PowerPC
Mac System 8.6
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.8.1

People

(Reporter: samir_bugzilla, Assigned: samir_bugzilla)

Details

(Whiteboard: [xpiprd])

Attachments

(4 files)

No description provided.
Keywords: nsbeta1
Priority: -- → P1
Whiteboard: [xpiprd]
Target Milestone: --- → mozilla0.8
Not happening for m0.8
Target Milestone: mozilla0.8 → mozilla0.9
Keywords: nsbeta1nsbeta1+
Attached patch Patch 1 of 3Splinter Review
Attached patch Patch 2 of 3Splinter Review
Attached patch Patch 3 of 3Splinter Review
In addition to the above pathces I will be checking in the GUSI libraries and source (which is under the zlib/libpng license and blessed by Frank Hecker and Mitchell Baker). I will also be checking in the xpnet.mcp project under mozilla/ xpinstall/wizard/libxpnet/macbuild. Don't plan on attaching the mac CodeWarrior project files unless requested by reviewers. Don, please r. Scott, Please sr. Thanks folks!
samir, these changes look good to me. But make sure Don gives them a good look over as you guys know what to look for more than I do =). One question though, I noticed you added a printf for dumping the download rate. Is this intended for debug purposes only? If so, can we wrap it in a ifdef DEBUG_sgehani or something?
Thanks Scott. The printf is in the TestLibxpnet.cpp test driver which I don't even plan on making part of the build (since the installers will use the lib and we can tell immediately if anything broke). Can I assume an sr?
Status: NEW → ASSIGNED
sr=mscott
Target Milestone: mozilla0.9 → mozilla0.8.1
sr=alecf
r=ssu
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Changing QA Contact to Grace.
QA Contact: jimmylee → gbush
verify build 20010319
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: