Closed
Bug 67248
Opened 24 years ago
Closed 24 years ago
Port libxpnet to the Mac
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.8.1
People
(Reporter: samir_bugzilla, Assigned: samir_bugzilla)
Details
(Whiteboard: [xpiprd])
Attachments
(4 files)
|
597 bytes,
patch
|
Details | Diff | Splinter Review | |
|
1.74 KB,
patch
|
Details | Diff | Splinter Review | |
|
3.48 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.42 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
| Assignee | ||
Updated•24 years ago
|
| Assignee | ||
Comment 2•24 years ago
|
||
| Assignee | ||
Comment 3•24 years ago
|
||
| Assignee | ||
Comment 4•24 years ago
|
||
| Assignee | ||
Comment 5•24 years ago
|
||
In addition to the above pathces I will be checking in the GUSI libraries and
source (which is under the zlib/libpng license and blessed by Frank Hecker and
Mitchell Baker). I will also be checking in the xpnet.mcp project under mozilla/
xpinstall/wizard/libxpnet/macbuild. Don't plan on attaching the mac CodeWarrior
project files unless requested by reviewers.
Don, please r.
Scott, Please sr.
Thanks folks!
Comment 6•24 years ago
|
||
samir, these changes look good to me. But make sure Don gives them a good look
over as you guys know what to look for more than I do =).
One question though, I noticed you added a printf for dumping the download rate.
Is this intended for debug purposes only? If so, can we wrap it in a ifdef
DEBUG_sgehani or something?
| Assignee | ||
Comment 7•24 years ago
|
||
Thanks Scott. The printf is in the TestLibxpnet.cpp test driver which I don't
even plan on making part of the build (since the installers will use the lib and
we can tell immediately if anything broke). Can I assume an sr?
Status: NEW → ASSIGNED
Comment 8•24 years ago
|
||
sr=mscott
| Assignee | ||
Updated•24 years ago
|
Target Milestone: mozilla0.9 → mozilla0.8.1
| Assignee | ||
Comment 9•24 years ago
|
||
Comment 10•24 years ago
|
||
sr=alecf
Comment 11•24 years ago
|
||
r=ssu
| Assignee | ||
Comment 12•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•