6744 - profile created has %20 in string rather than a space

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect, P2)

Description

[Kathleen :Brade]

I ran AppRunnerDebug today and was prompted (first time) to create a profile.
For the profile name I entered a string with a space in it:  "Mozilla Brade"
The actual folder created was named "Mozilla%20Brade"

Problems:
 * Difficult to find from the OS
 * Makes name even longer (file system on Mac is already limited to 31
characters)

Comment 1

[gayatrib]

Currently all special characters are being escaped.
So only alphabets and numericals can be used. We
will unescape the special characters in M7.

Comment 2

[gayatrib]

*** Bug 6702 has been marked as a duplicate of this bug. ***

Comment 3

[Kathleen :Brade]

Reopening.
This is not fixed with my build from this morning.

Comment 4

[racham]

*** Bug 7191 has been marked as a duplicate of this bug. ***

Comment 5

[Simon Fraser [no longer active]]

This bug cause loading mail folders to fail. Bumping priority to P2, cc:ing
putterman and ducarroz.

Comment 6

[scottputterman]

Adding lchiang to the cc list.  We need this fixed before we can have widespread
mac use, and we should probably put in the dialog some place that you can't
create a profile name with a space in it.

Comment 7

[lchiang]

The target milestone shows M9.  I'll add it to the M8 release notes tracking
bug for verah.

Comment 8

[gayatrib]

Changing the target milestone to M10.

Comment 9

[selmer (gone)]

*** Bug 12174 has been marked as a duplicate of this bug. ***

Comment 10

[selmer (gone)]

Bug 12174 is related in that profiles created before the escaping change can't
be accessed after the change.

Comment 11

[Grace Bush]

I don't see how this is working, creating a folder with a space in the name
creates a folder with %20 used for space. This does not show in Profile Manager,
but does show in Users50/grace%20bush

(using build 1999092708)

Comment 12

[selmer (gone)]

Seth, are you touching this area too?  Looks like we're probably creating the
directory with the encoded name rather than the plain text name.  Should be a
simple fix.

Comment 13

[(not reading, please use [e-mail] instead)]

re-assign to me.

Comment 14

[leger]

Clearing WORKSFORME resolution due to reopen of this bug.

Comment 15

[(not reading, please use [e-mail] instead)]

moving to m11.

Comment 16

[(not reading, please use [e-mail] instead)]

accepting.  marking all milestone 11.

Comment 17

[(not reading, please use [e-mail] instead)]

this should be fixed now.

If you created a profile "Foo Bar", it would be "Users50:Foo Bar"

there are a bunch of potential bugs lurking in this code.

1)  what if the profile name is too long for the native file system?  (we need
to hash the name of the directory on disk, if necessary)
2)  what if the profile matches a directory that already exists?
(we need to add a case insensitive check for existance.  FOOBAR and foobar are
the same directory on windows.)
3)  what about special characters?  (can the user ".." or "/" themselves into
trouble?)

marking this fixed, and I'll log the other issues as bugs and fix them.

Comment 18

[Grace Bush]

this is fixed in 1999100713 on the mac

Comment 19

[leger]

Moving all Profile Manager bugs to new Profile Manager Backend component.
Profile Manager component to be deleted.