675412 - browser-chrome xpinstall tests leak a lot

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dão Gottwald [:dao]]

See the URI list attached in bug 658738 -- lots of http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/* in there.

The amount of windows leaked makes me think that some central piece in the test framework or in the actual code must be responsible for this.

Comment 1

[Dão Gottwald [:dao]]

by test framework I mean toolkit/mozapps/extensions/test/browser/head.js

Comment 2

[Dão Gottwald [:dao]]

Err, more likely toolkit/mozapps/extensions/test/xpinstall/head.js

Comment 3

[Dave Townsend [:mossop]]

Perhaps related to bug 669240?

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Perhaps related to bug 669240?

Seems very likely.

Comment 5

[Serge Gautherie (:sgautherie)]

Ftr,
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1331186151.1331190870.3486.gz&fulltext=1
Linux comm-central-trunk debug test mochitest-other on 2012/03/07 21:55:51
{
[toolkit/mozapps/extensions/test/xpinstall/browser_whitelist2.js]
  1 window(s) [url = http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/installtrigger.html?%7B%22Unsigned%20XPI%22%3A%22http%3A%2F%2Fexample.org%2Fbrowser%2Ftoolkit%2Fmozapps%2Fextensions%2Ftest%2Fxpinstall%2Funsigned.xpi%22%7D]
  1 docShell(s)

[toolkit/mozapps/extensions/test/xpinstall/browser_whitelist5.js]
  1 window(s) [url = http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/startsoftwareupdate.html?%20http%3A%2F%2Fexample.com%2Fbrowser%2Ftoolkit%2Fmozapps%2Fextensions%2Ftest%2Fxpinstall%2Funsigned.xpi]
  1 docShell(s)

[toolkit/mozapps/extensions/test/xpinstall/browser_whitelist6.js]
  1 window(s) [url = http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/installchrome.html?%20http%3A%2F%2Fexample.com%2Fbrowser%2Ftoolkit%2Fmozapps%2Fextensions%2Ftest%2Fxpinstall%2Funsigned.xpi]
  1 docShell(s)
}

Comment 6

[Dão Gottwald [:dao]]

Bug 695480 made these leaks disappear.

Comment 7

[Serge Gautherie (:sgautherie)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=11220002&tree=Firefox&full=1
Rev3 WINNT 5.1 mozilla-central debug test mochitest-other on 2012-04-25 22:53:13 PDT for push cc5254f9825f

V.Fixed

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #5)
> http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1331186151.1331190870.
> 3486.gz&fulltext=1

Moved to bug 749532.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #7)

Oh, leaks are fixed, but code has a "remaining" issue:
{
TEST-INFO | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/xpinstall/browser_navigateaway2.js | Console message: [JavaScript Error: "can't access dead object" {file: "resource:///components/amWebInstallListener.js" line: 176}]
}

Code is
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/amWebInstallListener.js#175
117 Installer.prototype = {
...
126   checkAllDownloaded: function() {
...
176     if (failed.length > 0) {

PS: SeaMonkey didn't port this test (yet).

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We're clearly not going to do anything else in this bug.  If there are still issues file a followup please.