67578 - nsIMetaCharsetObserver service should explicitly register

Status: RESOLVED INVALID

(Core :: Internationalization, defect)

Description

[Judson Valeski]

Currently nsIMetaCharsetObserver has Start() and End() methods. All these 
methods do is register the meta charset observer w/ the observer service. 
There's no need for these methods as they can be replaced w/ open registration.

Comment 1

[Judson Valeski]

Attachment: new idl'ized version of cleaned up interface.

Comment 2

[Judson Valeski]

Attachment: changes to makefiles to use new idl file, and changes to charsetobserver to ditch the registrations.

Comment 3

[Judson Valeski]

Attachment: diffs to viewer app to registeter the metacharset observer.

Comment 4

[Judson Valeski]

Attachment: changes to the appshell to register the meta charset service as an observer.

Comment 5

[Judson Valeski]

These changes illustrate that nsIMetaCharsetService isn't needed. you can see 
that the methodless interface is just used to get at the service for 
registration, and that's it.

Comment 6

[nhottanscp]

Reassign to ftang.

Comment 7

[Frank Tang]

Of course you can do this. But why ?
Reassign to yokoyama

Comment 8

[Judson Valeski]

because it's confusing.

Comment 9

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 10

[Roy Yokoyama]

valeski:  I know have fix for 66020 which uses the nsICategoryManager, this bug 
should be changed to INVALID once I check the fix in for 66020.  
Do you agree?  Thanks

Comment 11

[Judson Valeski]

I agree.

Comment 12

[Roy Yokoyama]

Jud's approved status change.