67623 - javascript strict warnings in charsetOverlay.js

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P4)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://global/content/charsetOverlay.js line 191: reference to undefined
property window._content.document

JavaScript error:
chrome://global/content/charsetOverlay.js line 191: window._content.document has
 no properties

Comment 1

[nhottanscp]

It supposed to happen every page load but I did not see the warning, maybe 
fixed?

Comment 2

[Mark Olson]

This could have been a white elephant from related strict warnings at the time.
 Henrik, is this something that occurred along with the temporary (erroneous)
spike in js strict warnings? (reference bug 66928 and a couple other related bugs)

Comment 3

[nhottanscp]

I cannot reproduce this with today's pull.

Comment 4

[Henrik Gemal]

in build 2001022605:
JavaScript error:
chrome://global/content/charsetOverlay.js line 126: wnd.document has no 
properties

JavaScript error:
chrome://global/content/charsetOverlay.js line 126: wnd.document has no 
properties

to reproduce:
1) go to http://gemal1.sprawl.dk/
2) Choose View -> Char Code -> Customize -> Ok
3) Move into the View -> Char Code menu and you should get those errors..

Comment 5

[nhottanscp]

I tried as instructed but still cannot see the warning.
Below is what I see in the console.

Document http://gemal1.sprawl.dk/ loaded successfully
Update current charset: windows-1250
intl.charset.detector = off
WEBSHELL+ = 5
WEBSHELL- = 4
Update current charset: windows-1250
intl.charset.detector = off

Comment 6

[Henrik Gemal]

I'm still able to get these errors.
Try selecting a another charset and then move into the View -> Char Code menu 
and you should get those errors..

JavaScript strict warning:
chrome://global/content/charsetOverlay.js line 126: reference to undefined prope
rty wnd.document

JavaScript error:
chrome://global/content/charsetOverlay.js line 126: wnd.document has no properti
es

Comment 7

[nhottanscp]

Reassign to jbetak.

Comment 8

[[e-mail] (away - not reading bugmail)]

Gemal,

I've been assigned to look into this bug. It seems it is no-repro as of March
27. It might be a bogus warning as indicated by Mark Olson. As far as I remember
there was a great deal of "work in progress" on document properties and the JS
engine when Cata and I did the initial work on the code last spring, therefore
I'm only guardedly optimistic here...

The document.characterSet property is used in serveral places across the whole
product (when spawning a view source window, adding a bookmark or opening a new
browser window). Could you check any of these on http://gemal1.sprawl.dk/
 and look for the same warning?

Also, when doing wjust what you described in the bug (try selecting a another
charset and then move into the View -> Char Code menu) do you see this in your
console after the warning: Update current charset: windows-1250?

If you do, then the warning is likely to be bogus since the property was read
off the document property.

Gemal - thanks for all your trouble,
J.

Comment 9

[Henrik Gemal]

Cant reproduce this warning anymore. Only bug 60406.

Comment 10

[[e-mail] (away - not reading bugmail)]

closing - no repro as of 03/30/2001. Good candidate for regressions.

Comment 11

[Teruko Kobayashi]

Verified.