67636 - [RFE] show number of selected messages

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Jesse Ruderman]

rfe: when mutliple messages are selected in the thread pane, show the number of 
selected messages (and possibly also the total size of the messages) in the 
status bar.  This new text might replace the number of unread messages in the 
entire folder when multiple messages are selected.

Comment 1

[Vidar Haarr (not reading bugmail)]

*** Bug 154144 has been marked as a duplicate of this bug. ***

Comment 2

[Matthias Bockelkamp]

Attachment: Patch

Comment 3

[Matthias Bockelkamp]

Comment on attachment 130355 [details] [diff] [review]
Patch

doesn't apply any more

Comment 4

[Matthias Bockelkamp]

Attachment: Patch (updated)

updated patch

Comment 5

[[e-mail]]

Comment on attachment 151595 [details] [diff] [review]
Patch (updated)

Some trivial style nits I thought of but aren't worth fixing:

>+    if (GetNumSelectedMessages() > 1)
>+    {
>+      var numUnread =
>+            gMessengerBundle.getFormattedString("selectedMsgStatus",
>+                                                [GetNumSelectedMessages()]);
Could have used var numSelected = GetNumSelectedMessages();
Could have used ?: to select the string name

> function ThreadPaneSelectionChanged()
> {
>   if (!gRightMouseButtonDown)
>     GetThreadTree().view.selectionChanged();
>+  UpdateStatusMessageCounts(msgWindow.openFolder);
> }
Could have inserted the line at the start of the function

Comment 6

[Matthias Bockelkamp]

Attachment: Patch v2

- updated patch to apply cleanly
- followed neil's comments
- trying another superreviewer

Comment 7

[[e-mail]]

Comment on attachment 188096 [details] [diff] [review]
Patch v2

>+      gMessengerBundle.getFormattedString("selectedMsgStatus",[GetNumSelectedMessages()]) :
This line should reuse numSelected, and see the following comment.

>+      gMessengerBundle.getFormattedString("unreadMsgStatus",[folder.getNumUnread(false)]);        
Both of these lines are longer than 80 characters and should be wrapped using
the total messages as an example. In fact you should find that you are able to
reuse, rather than remove, the following two lines:
>-            gMessengerBundle.getFormattedString("unreadMsgStatus",
>-                                                [ folder.getNumUnread(false)]);

Comment 8

[Matthias Bockelkamp]

Attachment: Patch v3

followed your last review comments

Comment 9

[Matthias Bockelkamp]

Comment on attachment 188197 [details] [diff] [review]
Patch v3

file has changed...

Comment 10

[Matthias Bockelkamp]

Attachment: Patch v4

new try

Comment 11

[[e-mail]]

Attachment: Patch v4 with whitepsace fixes

Comment 12

[David :Bienvenu]

Comment on attachment 188259 [details] [diff] [review]
Patch v4 with whitepsace fixes

this will cause thunderbird to make an unneeded all to
UpdateStatusMessageCounts whenever selection changed, but we might add this rfe
to tbird...

Comment 13

[Benjamin Smedberg]

Comment on attachment 188259 [details] [diff] [review]
Patch v4 with whitepsace fixes

a=bsmedberg for landing July 5-6

Comment 14

[Matthias Bockelkamp]

Can someone check this in? Neil?

@bsmedberg: What happened to my approval request for 1.8b3? Is it denied?

Comment 15

[[e-mail]]

Fix checked in.

@mbockelcamp: the two approvals are roughly equivalent.

Comment 16

[Mike Cowperthwaite]

(In reply to comment #12)
> we might add this rfe to tbird...

bug 261512

Comment 17

[Stefan [:stefanh]]

Comment on attachment 188199 [details] [diff] [review]
Patch v4

Removing obsolete review requests.

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-07-09-06 on Windows XP: I checked local (which
also includes POP3 folders), NNTP (news) and IMAP folders.