Closed Bug 67755 Opened 24 years ago Closed 20 years ago

if you first do ok, get the alert about "list name exists", cancel will still change mailing list name in the UI

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7final

People

(Reporter: jdipu, Assigned: sspitzer)

Details

(Keywords: verified1.7, Whiteboard: fixed-aviary1.0)

Attachments

(1 file, 1 obsolete file)

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; m18) Gecko/20010201
BuildID:    2001020320

Trying to change the name of a mailing list to that of an existing one, will
give an alert saying not allowed, but later the Mailing List dialog box shows
the list name as the name, to which it was attempted to be changed(After
clicking Cancel, again open the mailing list).
After the Address Book window is closed and opened again, the original name (ie.
the correct one) will be shown in the
'Mailing List' Edit dialog box.


Reproducible: Always
Steps to Reproduce:
Bring up the Mozilla Navigator

Click on Tasks Menu->Address Book

Select the Address Book from Address Books

Select a list  entry in that Address Book from the thread window.

Select Edit option from Edit Menu

It displays mailing list  dialog to edit

Change the name to the same name as that of  an existing mailing list name in
the same address book

Click on OK button

Verify that an alert comes up saying " A mailing list with this name already
exists, choose different name"

Click on Cancel button.
Now again open the 'mailing list' edit dialog box for the same mailing list
(whose name was attempted to be changed).


Actual Results:  The name of the mailing list is shown as the name to which it
was attempted to be changed.

Expected Results:  The name of the mailing list should remain as the original name.

This problem is not seen if the Address book window is closed and then opened
again and then the 'Mailing List' Edit dialog box for that list is opened.
Confirmed
Platform:PC
OS: Linux 2.2.16
Mozilla Build: 2001020512

Marking NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 95 → All
Hardware: PC → All
changing qa to fenella
QA Contact: esther → fenella
QA Contact: fenella → nbaca
20020116 still valid. Weird bug..:)
Trunk build 2002-02-26-03: WinMe
I also reproduced the problem.
Clarification on my results:

Created list1, list2. Then tried to edit the name of list2 to "list1", received 
the warning and Canceled.

- Directory pane: shows both lists with the same name (list1)
- Results pane: shows the correct list names (list1, list2) but open list2 
and the name of the list is "list1"!

Workaround: Change list1 to "list2" you will get a warning that a list with that 
name already exists, Cancel and now the list names appear correct in the 
Directory Pane, the Results pane and after opening each mailing list.
Reassigning to myself
Assignee: chuang → srilatha
Attached patch proposed patch v1 (obsolete) — Splinter Review
Comment on attachment 89833 [details] [diff] [review]
proposed patch v1

looks good to me: r=varada
Attachment #89833 - Flags: review+
shortening summary per justdave's orders.  He says that Bugzilla will soon be
limiting summary length.
Summary: again open Trying to change the name of a mailing list to that of an existing one, will give an alert saying not allowed, but later the Mailing List dialog box shows the list name as the name, to which it was attempted to be changed(After clicking Cancel → alert changing mailing list name
I can reproduce this bug, I'll try the patch and land it if it works and looks good.
Assignee: srilatha → sspitzer
the patch isn't ideal.  I'll attach a new one.
Status: NEW → ASSIGNED
Summary: alert changing mailing list name → cancel will still change mailing list name, even if it exists
Attached patch better fix.Splinter Review
Attachment #89833 - Attachment is obsolete: true
updating summary.
Summary: cancel will still change mailing list name, even if it exists → if you first do ok, get the alert about "list name exists", cancel will still change mailing list name in the UI
Target Milestone: --- → mozilla1.7final
landing on trunk only, so tm is 1.8 a2.
Target Milestone: mozilla1.7final → mozilla1.8alpha2
fixed on trunk.

thanks to bienvenu for the r/sr.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: fixed-aviary1.0
Comment on attachment 149635 [details] [diff] [review]
better fix.

this has r/sr=bienvenu

worth taking for 1.7?
Attachment #149635 - Flags: superreview+
Attachment #149635 - Flags: review+
Attachment #149635 - Flags: approval1.7?
Comment on attachment 149635 [details] [diff] [review]
better fix.

a=chofmann for 1.7
Attachment #149635 - Flags: approval1.7? → approval1.7+
fixed on the 1.7 branch.
Keywords: fixed1.7
Target Milestone: mozilla1.8alpha2 → mozilla1.7final
Verified on 1.7 branch. Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7)
Gecko/20040623. old name is retained
Keywords: fixed1.7verified1.7
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: