Closed Bug 67896 Opened 24 years ago Closed 23 years ago

core dump on quitting - scrollbar XUL_ATOM is null

Categories

(Core :: XUL, defect, P3)

Sun
Solaris
defect

Tracking

()

RESOLVED WORKSFORME
mozilla0.8.1

People

(Reporter: bstell, Assigned: dr)

Details

(Keywords: crash)

Attachments

(1 file)

I'm running purify on Netscape_20000922_BRANCH on Solaris.
cvs update and build date: 10/9/2000.
I bring up the browser, the mozilla home page displays, I select
File->Quit and the mozilla core dumps on quit.



------- Additional Comments From bstell@netscape.com 2000-10-09 19:40:05 ----

Created an attachment (id=372)
Purify log (as text)




------- Additional Comments From bstell@netscape.com 2000-10-10 19:04:41 ----

Looks like we should free the atoms with a macro that checks for
null pointers:

This fixed the core dump for me:

Index: nsXULAtoms.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/xul/content/src/nsXULAtoms.cpp,v
retrieving revision 1.29
diff -u -r1.29 nsXULAtoms.cpp
--- nsXULAtoms.cpp      2000/04/16 11:18:22     1.29
+++ nsXULAtoms.cpp      2000/10/11 02:03:10
@@ -65,7 +65,7 @@
 
   NS_PRECONDITION(gRefCnt != 0, "bad release of xul atoms");
   if (--gRefCnt == 0) {
-#define XUL_ATOM(_name, _value) NS_RELEASE(_name);
+#define XUL_ATOM(_name, _value) NS_IF_RELEASE(_name);
 #include "nsXULAtomList.h"
 #undef XUL_ATOM




------- Additional Comments From lchiang@netscape.com 2000-10-10 20:00:50 ----

Who owns this file (module owner)?  I can't find this file using LXR.  I'm 
wondering if this is similar to some quit bugs which we have reported.  I'm not 
the right owner for this (hence, I was trying to find the module owner to 
reassign the bug to).

Is this a Solaris only file?



------- Additional Comments From bstell@netscape.com 2000-10-11 13:03:33 ----

I have seen this on Linux for a while but assumed that since it was so
serious someone else was working on it.

The core dump happens when the code tries to release the scrollbar
which is null.

(I have noticed the lxr.mcom.com cannot find all the files)
Try: http://lxr.mozilla.org/seamonkey/find?string=nsXULAtoms.cpp

From cvsblame on eamonkey/source/layout/xul/content/src/nsXULAtoms.cpp
=====================================================================
68 peterl   1.24 #define XUL_ATOM(_name, _value) NS_RELEASE(_name);
69               #include "nsXULAtomList.h"
70               #undef XUL_ATOM

From cvsblame for mozilla/layout/xul/content/src/nsXULAtomList.h
=====================================================================
 44 peterl 1.1  XUL_ATOM(button, "button")
 45             XUL_ATOM(spinner, "spinner")
 46             XUL_ATOM(scrollbar, "scrollbar")
 47             XUL_ATOM(slider, "slider")

The netscape phonebook does not list a peterl@netscape.com
does anyone know who peterl@netscape.com is ?



------- Additional Comments From peterlubczynski@netscape.com 2000-10-11 13:23:47 ----

This is a change made by Peter Linss who is no longer with Netscape. The alias 
peterl@netscape goes to peterlubczynski@netscape.com



------- Additional Comments From lchiang@netscape.com 2000-10-12 22:57:51 ----

cc: hyatt.  Hyatt, lxr shows you own this nsXULAtoms.cpp file.  Should this bug 
go to you? If not, any idea on who to reassign to?  Thanks.



------- Additional Comments From trudelle@netscape.com 2000-10-24 10:58:17 ----

->pavlov



------- Additional Comments From pavlov@netscape.com 2000-10-24 15:54:19 ----

why is this in bugscape?



------- Additional Comments From bstell@netscape.com 2000-10-24 17:32:07 ----

I should have put it there.




------- Additional Comments From knous@netscape.com 2001-02-06 13:30:37 ----

Netscape Nav Triage team: reassigning to vishy. this should be moved to bugzilla




------- Bug moved to this database by lchiang@netscape.com 2001-02-06 16:06 -------

This bug previously known as bug 2827 at http://bugscape.netscape.com/
http://bugscape.netscape.com/show_bug.cgi?id=2827
Originally filed under the Browser product and Browser-General component.

---
Unknown bug field "attachment" encountered while moving bug
<attachment>
  <attachid> 372 </attachid>
  <date> 10/09/00 19:40 </date>
  <desc> Purify log (as text) </desc>
</attachment>

Keywords: nsbeta1
QA Contact: lchiang → jrgm
Summary: core dump on quitting → core dump on quitting - releasing scrollbar
Attached file attaching purify log
re: transfering bug attachment failed
I just save the old attachment to a file and attached that file to the new bug
This looks like toolkit to me, back over to trudelle.
Maybe this was toolkit in the Netscape world and that got lost?

Assignee: vishy → trudelle
Status: NEW → UNCONFIRMED
Component: Browser-General → XP Toolkit/Widgets
Summary: core dump on quitting - releasing scrollbar → core dump on quitting - scrollbar XUL_ATOM is null
Marking NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: patch
->dr
Assignee: trudelle → dr
updating milestone, keywords, accepting
Status: NEW → ASSIGNED
Keywords: nsbeta1, patchcrash
Target Milestone: M18 → mozilla0.9
->0.8.1 (can and will fix by 3/14)
Priority: P2 → P3
Target Milestone: mozilla0.9 → mozilla0.8.1
This was a branch issue, and the nsXULAtoms code has gotten quite whacked since
then. Pavlov sez: worksforme.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.