Closed Bug 68075 Opened 24 years ago Closed 24 years ago

Need to optimize CreateInstances of unicode to MacRoman converters, and Unicode helpers

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Platform:
All
Mac System 8.5
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: sfraser_bugs, Assigned: nhottanscp)

Details

Attachments

(3 files)

patch, cache unicode encoder in the class
3.93 KB, patch
Details | Diff | Splinter Review
New patch after Erik's review.
3.49 KB, patch
Details | Diff | Splinter Review
Patch, forgot to free the memory in case of errors
3.62 KB, patch
Details | Diff | Splinter Review 
Some analysis of XPCOM logs shows that just starting up Mozilla and displaying a 
simple, text-only HTML page involves 625 CreateInstances of 
NS_UNICODETOMACROMAN_CID, and 625 of NS_UNICODEENCODEHELPER_CID. This seems very 
high, and should be optimized.
Some places where we make nsUnicodeToMacRoman converters:
    nsCharsetMenu::ReorderMenuItemArray-> NS_QuickSort
(this looks like bug 64146). EVERY comparison in side that quicksort call
does CreateInstance of a converter! It looks like nsCollation::UnicodeToChar or 
something thereabout should cache the converter.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
using nhotta's account:  /r=yokoyama
Keywords: review

    
    

    
  
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

    
    

    
  
Hotta san, please mark as fixed.
Status: RESOLVED → VERIFIED
QA Contact: teruko → nhotta

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: