Closed
Bug 68075
Opened 25 years ago
Closed 25 years ago
Need to optimize CreateInstances of unicode to MacRoman converters, and Unicode helpers
Categories
(Core :: Internationalization, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: sfraser_bugs, Assigned: nhottanscp)
Details
Attachments
(3 files)
|
3.93 KB,
patch
|
Details | Diff | Splinter Review | |
|
3.49 KB,
patch
|
Details | Diff | Splinter Review | |
|
3.62 KB,
patch
|
Details | Diff | Splinter Review |
Some analysis of XPCOM logs shows that just starting up Mozilla and displaying a
simple, text-only HTML page involves 625 CreateInstances of
NS_UNICODETOMACROMAN_CID, and 625 of NS_UNICODEENCODEHELPER_CID. This seems very
high, and should be optimized.
|
Reporter | |
Comment 1•25 years ago
|
||
Some places where we make nsUnicodeToMacRoman converters:
nsCharsetMenu::ReorderMenuItemArray-> NS_QuickSort
(this looks like bug 64146). EVERY comparison in side that quicksort call
does CreateInstance of a converter! It looks like nsCollation::UnicodeToChar or
something thereabout should cache the converter.
|
Assignee | |
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
|
|
Assignee | |
Comment 2•25 years ago
|
||
|
|
Assignee | |
Comment 3•25 years ago
|
||
using nhotta's account: /r=yokoyama
|
|
Assignee | |
Comment 4•25 years ago
|
||
|
|
Assignee | |
Comment 5•25 years ago
|
||
|
|
Assignee | |
Comment 6•25 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
||
Comment 7•24 years ago
|
||
Hotta san, please mark as fixed.
Status: RESOLVED → VERIFIED
QA Contact: teruko → nhotta
You need to log in
before you can comment on or make changes to this bug.
Description
•