68110 - Installer fails - Proxy requests incorrect

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[benc]

Commercial Win32 2001-02-05-09 (actually any build since the new installer code 
was checked-in).

BACKGROUND:

The new code implements a new Proxy dialog (you can now specify user and 
password in the wizard).

This was also the code that was creating all those "too many" errors.

PROBLEM:
The proxy requests are composed incorrectly. Here's a sample of the logs from a 
failed install, ignore everyrthing except the "GET..." part of the log entries.

208.12.40.178 - - [05/Feb/2001:13:30:54 -0800] "GET /xpcom.xpi HTTP/1.1" 401 246
 - - - - 30 191 - - -
208.12.40.178 - - [05/Feb/2001:13:30:54 -0800] "GET /browser.xpi HTTP/1.1" 401 2
46 - - - - 30 191 - - -
208.12.40.178 - - [05/Feb/2001:13:30:54 -0800] "GET /jre13i.exe HTTP/1.1" 401 24
6 - - - - 30 191 - - -
208.12.40.178 - - [05/Feb/2001:13:30:55 -0800] "GET /mail.xpi HTTP/1.1" 401 246
- - - - 30 191 - - -
208.12.40.178 - - [05/Feb/2001:13:30:55 -0800] "GET /nim.xpi HTTP/1.1" 401 246 -
 - - - 30 191 - - -
208.12.40.178 - - [05/Feb/2001:13:30:55 -0800] "GET /talkback.xpi HTTP/1.1" 401
246 - - - - 30 191 - - -
208.12.40.178 - - [05/Feb/2001:13:30:56 -0800] "GET /psm.xpi HTTP/1.1" 401 246 -
 - - - 30 191 - - -
208.12.40.178 - - [05/Feb/2001:13:30:56 -0800] "GET /spellchk.xpi HTTP/1.1" 401
246 - - - - 30 191 - - -

The proxy should be receiving requests that are "GET <URL>". The installer 
seems to send "GET /<filename>". (Proxy requests are formatted differently than 
normal HTTP requests)

The new code is probably not composing the request correctly, because it seems 
to be using just referencing the file, rather than composing a full ftp or http 
URL.

Strangely the first request for redirect.ini seems to be formated correctly:
208.12.40.178 - - [30/Jan/2001:16:58:23 -0800] "GET ftp://ftp.netscape.com/pub/n
etscape6/english/6.01/windows/win32/redirect.ini HTTP/1.0" 407 271 - - - - 1227
263 - - -

This probably should be fixed for whatever milestone we originally promised to 
fix this.

Comment 1

[Sean Su]

accepting this.

Comment 2

[[e-mail]]

Attachment: access log

Comment 3

[[e-mail]]

The log entry for redirect.ini was incorrect, causing some confusion.

I have re-tested the problem, and attached a log file of the entire session.

The correct entry for the request.ini is:

208.12.40.178 - - [09/Feb/2001:14:46:43 -0800] "GET
ftp://sweetlou.mcom.com/products/client/seamonkey/windows/32bit/x86/2001-02-08-08-Mtrunk/redirect.ini
HTTP/1.1" 500 436 - - - - 146 111 - - 0

This is caused by my test proxy being on an external network, that cannot go
back to the netscape.com corporate network.

The result seems to be that without request.ini, the subsequent proxy requests
lack a prefix, since request.ini appears to be a list of directories written as
ftp URL's.

I have heard that request.ini is supposed to be optional, so this is probably
stil a legitimate bug.

Comment 4

[Sean Su]

Ben, I think I fixed this now.  I believe the problem was that since you could 
not get back into the corporate network, a zero byte length redirect.ini file 
was created.

The code only used to check for the existence of the redirect.ini file, not also 
its contents.  It does both now.  But you are correct that the redirect.ini file 
feature will be disabled in the future.  I'm working on it :)

Comment 5

[[e-mail]]

I'll verify this as soon as I can get a daily build.

Comment 6

[Grace Bush]

taking all proxy related bugs

Comment 7

[Grace Bush]

this is working again with new proxy fixes

Comment 8

[robodh]

[Tracking Requested - why for this release]: