68139 - Radio-button values not available through JavaScript

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[dwallace]

I will try to attach my testcase after this. I am using the onClick attribute of
an anchor tag to call a JavaScript function that reads the value of a set of
checkboxes to build a URL. Apparently, "document.forms[0].radioid[i].value"
returns the value "on" for a checked checkbox. Netscape and IE return the value
attribute of that checkbox.

This may be related to http://bugzilla.mozilla.org/show_bug.cgi?id=65168 but
seems different enough that I am submitted a separate report.

Using Mozilla/5.0 (X11; U; Linux 2.2.18 i686; en-US; m18) Gecko/20010207
but I have been noticing the problem in nightlies for about a week now.

Comment 1

[dwallace]

Attachment: Simple test of getting checkbox values through JavaScript

Comment 2

[Doron Rosenberg (IBM)]

confirming, seeing on 2001020804 win98

->dom0 i believe

Comment 3

[Nate Thompson]

Confirming.  On 2001020721 linux.

Simple call to document.FormName.RadioName[i].value returns "on" instead of
value.  In talking with a few people on #mozilla it looks like
getAttribute('value') works.

Comment 4

[Nate Thompson]

Attachment: Testcase which shows behavior of both ".value" and ".getAttribute('value')

Comment 5

[Boris Zbarsky [:bzbarsky]]

getAttribute('value') and .value do totally different things.

getAttribute('value') does the same thing as .defaultValue

Comment 6

[Fabian Guisset]

johnny, might this be due to your checkin that returns "on" for .checked?

Comment 7

[Johnny Stenback (:jst)]

Attachment: Proposed fix

Comment 8

[Johnny Stenback (:jst)]

This is a regression I caused when fixing bug 44615, I thought I had tested the
fix in that bug in all cases I could think of but obviously I missed the obvious
case, duh!

Anyway, the attached patch fixes this problem w/o breaking the testcase in bug
44615.

Comment 9

[Doron Rosenberg (IBM)]

i think this should warrant 0.8 checkin, as a lot of sites use this for error
checking of forms. nominating for that and cc:'ing asa

Comment 10

[harishd]

patch [ id=24785 ] look good. r=harishd

Comment 11

[vidur (gone)]

sr=vidur

Comment 12

[Johnny Stenback (:jst)]

*** Bug 68268 has been marked as a duplicate of this bug. ***

Comment 13

[Asa Dotzler [:asa]]

a=blizzard/asa for checkin to 0.8

Comment 14

[Johnny Stenback (:jst)]

Thanks for the reviews n' approvals, fix checked in.