68169 - Embedding sample needs to use new nsIWebBrowserFind API

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Conrad Carlen (not reading bugmail)]

The nsIWebBrowserFind API and impl made it into mozilla0.8. However, none of the
embedding samples are using it. This makes the Mac embedding sample use it.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch to use new iface and get rid of old way

Comment 2

[Conrad Carlen (not reading bugmail)]

In addition to the patch, I need to remove the old find impl from the Mac embed
project. This code was only used by that sample.

Comment 3

[Judson Valeski]

r=valeski

Comment 4

[Brendan Eich [:brendan]]

r= suffices for sample code, unless it's about to become real in-process code
tied to super-reviewed parts of the tree.  Provided this stuff is all not in the
build, go ahead and check in, I say.

/be

Comment 5

[Simon Fraser [no longer active]]

r=sfraser

Comment 6

[Asa Dotzler [:asa]]

a=asa for checkin to 0.8

Comment 7

[Conrad Carlen (not reading bugmail)]

New code checked in.

Comment 8

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 9

[David Epstein]

in CBrowserShell.cpp, verified code changes to both forms of
CBrowserShell:Find(). Also, CanFIndNext() and FindNext(). EnsureFinder() &
GetFindParams() were removed. DoFindDialog() was added.