68247 - Search: Open (and future File, Delete) button should be moved to right of results.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using feb8 commercial trunk builds

Open button is implemented, but is in a bad location within the search messages
dialog.  The Open, File and Delete buttons should be placed to the right side of
the results pane per spec (don't see the search spec yet posted on mozilla.org),
but available internally to netscape.

The Open button is currently positioned along the bottom of the dialog adjacent
to the Close (close dialog) button. This positioning is confusing.

Comment 1

[Jesse Ruderman]

Would it be sufficient to align the buttons (except for Close) along the left 
of the bottom of the window?  I'm worried that putting buttons to the right 
might make the tree too narrow to see the subject/sender/date easily.

Comment 2

[scottputterman]

marking nsbeta1-

Comment 3

[jglick]

Attachment: Screenshot of Open message in wrong location

Comment 4

[jglick]

Attachment: Correct location of Open button

Comment 5

[jglick]

Open button really shouldn't be grouped with the window control button (Close) 
at the bottom.

Comment 6

[jglick]

OK, now that the Delete and File buttons have been added in the wrong location 
also, this dialog looks really bad.  Buttons used to perform functionality on 
the window, Delete and Open, should not be group with the "Close" button.  The 
File button is the wrong widget type and is located off to the bottom left of 
the dialog on its own.  This is just sloppy.  Removing minus so this bug is 
reconsidered.

Comment 7

[jglick]

Attachment: Open, Delete and File buttons in wrong location

Comment 8

[scottputterman]

*** Bug 73411 has been marked as a duplicate of this bug. ***

Comment 9

[scottputterman]

I just marked 73411 as a dup.  Not only is file in the wrong place, but it also
needs to use the correct widget.

marking nsbeta1+

Comment 10

[andreww]

reassigning bug to me - hope that's ok - talked to putterman about it.

Comment 11

[andreww]

xul is ready - but I need to add a new css class to make the menubutton look 
right.

Comment 12

[hangas]

Themes Triage Team Marking nsbeta1+ (was + in status from mailnews)

Comment 13

[Tuukka Tolvanen (sp3000)]

Also, now, pressing enter after selecting some search results deletes the
selected messages, which is surprising ...I would rather see them opened instead.

Comment 14

[laurel]

In answer to the last comment (by Tuukka), the Enter==delete problem is covered
under bug 74407.  

Comment 15

[andreww]

Attachment: diffs for searchDialog.xul

Comment 16

[andreww]

patch submitted, ready for review.

Comment 17

[Doron Rosenberg (IBM)]

patch looks good, some tabbing space issues though

+       <box orient="vertical">
+       		<spring flex="1" />

for example. Other than that, r=[e-mail]

Comment 18

[andreww]

Attachment: diffs for searchDialog.xul and searchDialog.dtd

Comment 19

[andreww]

created new patch with fixes for delete button - it wasnt using a DTD .

The File button isnt moved yet because the default look for that button has not 
yet been created, so it might not look right there between the other two buttons.


There (is/will be)  another bug filed on there not being a default look for 
menubuttons.

Comment 20

[Doron Rosenberg (IBM)]

btw, there are still some tabbing issues in that patch.

Comment 21

[andreww]

righto - Ill fix the tab issues before checking it in.

Comment 22

[andreww]

sr courtesy of  sspitzer

Comment 23

[andreww]

fix checked into tree 

Comment 24

[laurel]

Using apr12 commercial trunk build with win98, linux rh6.2, mac OS 9.0:

OK for Open and Delete buttons -- they've been moved to side of results list box.
What about the File button -- who's going to move it and should we reuse this
bug for it or log another?  

Comment 25

[gayatrib]

Andrew is working on getting the correct widget for the file button. I think it 
would be best to file another bug and assign it to him.

Comment 26

[andreww]

bug 62722 covers the editable menulists not being implemented. I would say file
a new bug on the file button after that comes in.  So file a new bug on file not
being in the right place, send it to me, and Ill set 62722 as depends, then fix
that bug after 62722 gets fixed.

Comment 27

[laurel]

Marking verified.
New report is bug 75812.