68260 - Charset converters print loads of debugging information during registration

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Brian Ryner (not reading)]

I count about 150 lines of debugging output that are printed every time the
uconv modules are registered, even on non-debug builds.  I've got a patch to
only show the output #ifdef DEBUG (although I question how useful this is to
anyone outside the intl team, even in debug builds).

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[nhottanscp]

Reassign to yokoyama, cc to ftang.

Comment 3

[Roy Yokoyama]

Brian: Thanks for the patch. Patch looks good.   /r=yokoyama
You can remove the printf() unless ftang has objections.
Should I assign this to you, Brian?

Comment 4

[Brian Ryner (not reading)]

ftang? any thoughts on this?

Comment 5

[Frank Tang]

either way

Comment 6

[Roy Yokoyama]

ftang: can you give /sr=?

Comment 7

[Erik van der Poel]

There should not be a semicolon (;) after the printf statement. Also, in the
non-DEBUG case, the macro should not be defined as {}, since that would fail
when you use the macro in an if statement. For example:

  if (...)
    REGSELF_PRINTF(...);
  else
    ...

Just leave the macro empty for non-DEBUG.

sr=erik

Comment 8

[Roy Yokoyama]

assigning to [e-mail]

Comment 9

[Brian Ryner (not reading)]

checked in.

Comment 10

[Teruko Kobayashi]

Roy, please verify this.