68395 - Bookmarks button still shows when turned off in preferences

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[db]

On a new profile in the Preferences->Navigator, there is a toolbar section with

Bookmark
Go
Home
Print
Search

where the last three is initially selected. Still, in the browser the bookmarks
are activated even if it's not checked here in the prefs. To deactivate
bookmarks one have to select bookmark, press OK, no change. Go back, unselect
bookmark, press OK. And now it's gone in the browser

The same thing in the Preferences->Navigator->Bookmarks prefs page. The "Always
ask me ..." setting is active in the browser but not checked. Also, when I open
this prefs page i get this:

chrome://communicator/content/bookmarks/pref-bookmarks.xul line 52: rName has no
properties


There seems to be some error in the model-view handling that one usually uses
for these things. It seems like the prefs-window have one model that is not
updated from the browser model. Ar least they down match.

This is on linix, build 2001020908

Comment 1

[Matthew T (active 1999-2002)]

Ben's fault, I think.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I see this in the 2001-02-11-06 build on Linux.

Comment 3

[gary_Cope]

*** Bug 68760 has been marked as a duplicate of this bug. ***

Comment 4

[Mike Pinkerton (not reading bugmail)]

triaging per ben's request

Comment 5

[sairuh (rarely reading bugmail)]

*** Bug 69553 has been marked as a duplicate of this bug. ***

Comment 6

[Håkan Waara]

Yeah I saw this too.

Workaround:

Open prefs,  click Bookmarks checkbox,  Click OK in prefs

Now you can either go back and uncheck it again, this will result in the
bookmarks folder disappearing from the toolbar. Or you can have it there.

Reporter, if you start from a new profile - does this occur for you then? I
guess this bug might have something to do with a new pref which is initially
default set to true...

Comment 7

[Paul Chen]

Mass moving most of mozilla0.9 bugs to mozilla0.8.1

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to fix.

Comment 9

[Richard Hurt]

I see this happening every time I install a nightly.  To install, I completly
rid my computer of Mozilla removing c:\program files\mozilla.org\*;
c:\winnt\moz*; c:\winnt\profiles\myprofile\application data\mozilla.

WinNT 4.0 SP5
IBM ThinkPad 600e
224MB RAM
6GB HD (200MB free)

Comment 10

[Peter "jag" Annema]

No need to touch all.js, just add the hidden attribute to bookmarks-button, per
irc. r=jag with that change.

Comment 11

[Claudius Gayle]

*** Bug 71353 has been marked as a duplicate of this bug. ***

Comment 12

[Alan S. Jones]

*** Bug 70815 has been marked as a duplicate of this bug. ***

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Fix checked in

Comment 14

[Claudius Gayle]

*** Bug 72140 has been marked as a duplicate of this bug. ***

Comment 15

[Claudius Gayle]

almost fixed. with a new profile the default is to have this button
on(and it is) but the pref is unchecked. Checking the pref correctly results
in the button staying visible, it's just that the initial conditions
don't match.

Comment 16

[Claudius Gayle]

that was with the 2001032908 builds by the way, and this is actually still
exactly as the reporter originally described it.

Comment 17

[Peter "jag" Annema]

I see what happened here. In the patch, the bookmarks button was hidden by
default (hidden="true"), but Ben checked in hidden="false". That change however
requires all.js to be updated too, which wasn't needed when the button was
hidden by default.

Either navigator.xul needs to be fixed to have the button hidden by default, or
all.js needs to be fixed to mark the button as shown.

Comment 18

[Paul Chen]

nav triage team:

Marking nsbeta1+, mozilla0.9, reassigning to pchen

Comment 19

[Paul Chen]

Samir is going to take some of my bugs. Yeah! Reassigning to Samir

Comment 20

[Samir Gehani]

Attachment: Sync all.js to reflect bookmarks is on by default (2nd half of ben's original patch essentially).

Comment 21

[Samir Gehani]

pchen, please r.
alecf, please sr.

Thanks!

Comment 22

[Peter "jag" Annema]

r=jag

Comment 23

[Alec Flett]

sr=alecf

Comment 24

[Samir Gehani]

Fix checkec in.

Comment 25

[Paul Chen]

*** Bug 75818 has been marked as a duplicate of this bug. ***

Comment 26

[Claudius Gayle]

VERIFIED Fixed on 2001051508 builds