68496 - Renaming a bookmark does not work

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[avi]

In bookmark manager: When trying to rename a URL by either clicking on the URL
and editing the text or by bringing up the menu and selecting rename, the new
name does not 'stick'.  The only way I found to do the rename is through the
properties.

Comment 1

[Fabian Guisset]

what buildID are you using plz? the bookmarks manager has had a number of fixes
since it was changed.

Comment 2

[avi]

Mozilla's build ID is 2001020909

Comment 3

[Håkan Waara]

I can't rename bookmarks through that inline-editing stuff either!

Marking NEW. OS/Platform All. (tested on Windows98). Severity major.

Asa, if this is an easy fix, is this possible to get in for 0.8? This is a
really nice feature and the bug screws up a major functionality thing.

Comment 4

[Boris Zbarsky [:bzbarsky]]

I am seeing the following behavior here:

1) click on bookmark.
2) click on the same bookmark again, or select rename from the context menu
3) edit the name
4) click elsewhere in the bookmark manager window.

The new name is not saved.

If instead I do

4a) hit enter (after editing name)

the name is saved.

Comment 5

[basic]

I think the problem is more of clicking behavior, should clicking another part
of the bookmark cancel the rename or not. On ms windows, explorer does not
cancel renaming when clicking another part of the window. What is the behavior
on Mac? Gnome? KDE? OS/2?

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

my mistake. Not sure exactly why I got this wrong.

Comment 7

[Paul Chen]

Should fix for beta1, marking nsbeta1+

Comment 8

[Håkan Waara]

*** Bug 68612 has been marked as a duplicate of this bug. ***

Comment 9

[Håkan Waara]

If you could make clicking outside the inline-editing field call the same
save-change code as hitting enter then this would be fixed.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

I believe I have fixes for this in my tree.

Comment 11

[Paul Chen]

Mass moving most of mozilla0.9 bugs to mozilla0.8.1

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Fix checked in. 

Comment 13

[Claudius Gayle]

so this doesn't work at all with 2001032908 builds. I believe it may
have been fixed and regressed again since then. Regardless, it doesn't work now.

Comment 14

[Boris Zbarsky [:bzbarsky]]

The fact that it does not work now is a result of Blake's landing and is covered
by bug 73184, which has a patch attached that fixes the problem. 

Comment 15

[Claudius Gayle]

...so I'll mark it as depends and when that one gets fixed we can come back and verify this one,
since it wouldn't be correct to dupe this one.

Comment 16

[Andreas Franke (gone)]

Bug 73184 is a verified duplicate of bug 68537 which has been marked fixed by
Ben Goodger 2001-04-17 21:54. Thus it may make sense to re-test this bug.
(If this bug is still alive, the target milestone needs to be reset.)

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

Please verify that the bug still exists before reopening, rather than reopening 
to prompt verification ;) 

This bug remains fixed. 

Comment 18

[Håkan Waara]

I can rename a bookmark by editing the name inline and then pressing <enter>,
but when I try to edit the name and then clicking outside the rect, the
textfield persists instead of going away and apply the change!

Please reopen this.

Comment 19

[Asa Dotzler [:asa]]

Worksforme.  Tested:
win32 build 041904
linux build 041908
mac build 041908

I tested this: opened Bookmark Manager, right-clicked on a bookmark and selected
Rename menuitem.  The bookmark name became an editable field.  I renamed the
bookmark and hit enter.  The editable field was gone and the new name looked
fine.  I also tried renaming and then clicking on another bookmark to dismiss
the editable field and this also worked.  This bug is fixed as far as I can tell.

Comment 20

[Claudius Gayle]

what Asa said. Truth be told i'm amazed at how well this worked. I even used 'Esc' to reset the
old title after I'd deleted it in the edit field. And yes, Håkan i tried clicking out of the edit field
instead of hitting return ;-) that worked too.

VERIFIED FIXED with all 200104190x builds (please everybody always use build dates)