68525 - javascript strict warnings in mailWindowOverlay.js

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://messenger/content/mailWindowOverlay.js line 381: assignment to undeclar
ed variable destUri

JavaScript strict warning:
chrome://messenger/content/mailWindowOverlay.js line 382: assignment to undeclar
ed variable destResource

JavaScript strict warning:
chrome://messenger/content/mailWindowOverlay.js line 383: assignment to undeclar
ed variable destMsgFolder

Comment 1

[Håkan Waara]

Taking from sspitzer, I've got a patch coming up...

Comment 2

[Håkan Waara]

Attachment: (Av1) Fixing the errors this bug's about, but also some other errors I spotted and some general code cleanup. [Checked in: Comment 7]

Comment 3

[timeless]

r=timeless

Comment 4

[Håkan Waara]

Seth, please sr= these small changes. Thanks!

Comment 5

[Alec Flett]

sr=alecf

Comment 6

[(not reading, please use [e-mail] instead)]

sorry for the delay.  

thanks for helping me out, alecf.

these changes look good.  I'll land them today.

Comment 7

[(not reading, please use [e-mail] instead)]

fixed

Comment 8

[Henrik Gemal]

Why are these suddenly seen again in build 2001032508 ?

JavaScript strict warning:
chrome://messenger/content/mailWindowOverlay.js line 447: assignment to undeclar
ed variable destUri

JavaScript strict warning:
chrome://messenger/content/mailWindowOverlay.js line 448: assignment to undeclar
ed variable destResource

JavaScript strict warning:
chrome://messenger/content/mailWindowOverlay.js line 449: assignment to undeclar
ed variable destMsgFolder

Comment 9

[Håkan Waara]

Attachment: (Av2) fix for the new errors. please r=, sr= [Checked in: Comment 13]

Comment 10

[(not reading, please use [e-mail] instead)]

sr=sspitzer

the original fix must have changes must have gotten stomped by the mailnews perf 
branch landing.

Comment 11

[Håkan Waara]

need r= to checkin...

Comment 12

[timeless]

r=timeless

Comment 13

[Håkan Waara]

Fix checked in.

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

Where am I supposed to see these errors?  I looked at hwaara's first patch,
looks like if I copy message and move messages, correct?

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

I copied and moved 5 messages to both local folders and IMAP folders, didn't see
any warnings.  If that's the case, then I can mark this verified, just let me
know, thanks.

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

verified.

Comment 17

[Henrik Gemal]

Whenever there is new functionality there's new js warnings!
Please add the following line to your prefs.js file, so we could avoid all the 
strict warning fixup...:
user_pref("javascript.options.strict", true);

Build 20010708:

Warning: redeclaration of var folder
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 467, Column: 10

Warning: function PromptGetMessagesOffline does not always return a value
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 1199

Warning: function PromptSendMessagesOffline does not always return a value
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 1219

Comment 18

[Håkan Waara]

It's a simple fix, but I'm tired of cleaning after others.

Mohan's big patch caused this. Reassign.

Comment 19

[[e-mail] (gone - use [e-mail] instead)]

Attachment: (Bv1)

Comment 20

[scottputterman]

reassigning to ssu.

Comment 21

[Sean Su]

Comment on attachment 46660 [details] [diff] [review]
(Bv1)

r=ssu for stephend's patch

Comment 22

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 46660 [details] [diff] [review]
(Bv1)

>Index: mailWindowOverlay.js
>===================================================================
>RCS file: /cvsroot/mozilla/mailnews/base/resources/content/mailWindowOverlay.js,v
>retrieving revision 1.81
>diff -u -r1.81 mailWindowOverlay.js
>--- mailWindowOverlay.js	2001/08/15 05:07:10	1.81
>+++ mailWindowOverlay.js	2001/08/21 21:59:24
>@@ -432,6 +432,7 @@
>       GetMessagesForAllAuthenticatedAccounts();
>     }
>   }
>+  return true;

I don't trust my returns on this.  

> }
> 
> /**
>@@ -463,7 +464,7 @@
> function MsgGetNextNMessages()
> {
>   if(CheckOnline()) {
>-    var folder = GetFirstSelectedMsgFolder();
>+    folder = GetFirstSelectedMsgFolder();

This is already fixed in the trunk.

>     if(folder) 
>       GetNextNMessages(folder);
>   }
>@@ -1250,6 +1251,7 @@
>       return buttonPressed.value;
>     }
>   }
>+  return true;

I don't trust my return on this, either.

> }
> 
> function GetFolderMessages()

Comment 23

[Oliver Klee]

Here's some more:

Warning: reference to undefined property
Components.classes['@mozilla.org;timeline-service;1']
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 34

Error: Components.classes['@mozilla.org;timeline-service;1'] has no properties
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 34

Comment 24

[[e-mail] (gone - use [e-mail] instead)]

Oliver, the timeline warnings are bug 119250...

Comment 25

[Henrik Gemal]

*** Bug 119250 has been marked as a duplicate of this bug. ***

Comment 26

[Henrik Gemal]

in 20020326 we have:
Warning: function PromptGetMessagesOffline does not always return a value
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 1448
Source Code:
}

Warning: function PromptSendMessagesOffline does not always return a value
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 1468
Source Code:
}

Comment 27

[Serge Gautherie (:sgautherie)]

Comment on attachment 46660 [details] [diff] [review]
(Bv1)


The |folder| warning was bug 100906...

The "return a value" warnings were fixed by bug 128905.