Closed
Bug 68662
Opened 24 years ago
Closed 23 years ago
Browser UI doesn't update after skin switch
Categories
(Core Graveyard :: Skinability, defect)
Core Graveyard
Skinability
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9
People
(Reporter: jag+mozbugs, Assigned: jag+mozbugs)
References
Details
Attachments
(3 files)
7.41 KB,
patch
|
Details | Diff | Splinter Review | |
10.65 KB,
patch
|
Details | Diff | Splinter Review | |
12.25 KB,
patch
|
Details | Diff | Splinter Review |
After switching skins, the browser UI no longer updates. This bug was introduced with the checkin to nsBrowserInstance.cpp on Jan 4 which refactored some of the code in there, by no longer reinitializing the content variables, amongst which registering the web progress listener with the new content window's docshell, if the old content window had gone away. I've got a fix, now I just need to write it :-)
Assignee | ||
Comment 3•23 years ago
|
||
No, that's another, unrelated, bug.
Comment 4•23 years ago
|
||
jag, should we get this into 0.8 at the last minute? /be
Assignee | ||
Comment 5•23 years ago
|
||
Well, this turns out to be a bit trickier than I thought it was. I've got something which works like things worked before my changes, but it turns out that even before those changes, clicking links after switching themes would not update the browser UI. The listener object (BrowserInstance) needs to be registered with the new content docshell, and that doesn't happen for link clicking. I'm investigating an ugly hack at the moment which could fix that too.
Assignee | ||
Comment 6•23 years ago
|
||
Nah, the hack is too ugly for 0.9 and too big a risk for 0.8. The work-around is to open a new browser window and close the current one, or close Mozilla and start again. I'll work on a better fix for 0.9.
Target Milestone: --- → mozilla0.9
Comment 7•23 years ago
|
||
Jag, you may find these bugs interesting : 61796, 61991, 68230, 68227.
Comment 8•23 years ago
|
||
-> skinability
Assignee: disttsc → ben
Component: XP Apps → Skinability
QA Contact: sairuh → blakeross
Assignee | ||
Comment 10•23 years ago
|
||
Assignee | ||
Comment 11•23 years ago
|
||
Comment 12•23 years ago
|
||
cool... I like this way of solving it. :) sr=alecf
Comment 13•23 years ago
|
||
jag tells me that this is an intermediate stage in browser cleanup work, so an r=ben@netscape.com for this change.
Comment 14•23 years ago
|
||
I noticed UI breakage with 2001031008 on win98se after applying a theme. The back button's dropdown menu didn't work and the address bar stopped updating itself as I surfed. It looks like this bug has an r and sr...when's it gonna be checked in?
Assignee | ||
Comment 15•23 years ago
|
||
As soon as I find out why I can't get the SecureBrowserUI component to get hooked up again (it's what sets the little lock icon corresponding to the page you're viewing). It should all theoretically work, but apparantly our browser thinks differently ;-) I'll need to get a build which doesn't crash on me to get some progress there, though I may land this patch as-is for 0.8.1 and work from there. alecf, what say you?
Comment 16•23 years ago
|
||
I'd like to see this go in for 0.8.1 a=asa on behalf of drivers. Not sure what's happening with the tree yet but when we are ready to start taking checkins let's get this in.
Assignee | ||
Comment 17•23 years ago
|
||
Comment 18•23 years ago
|
||
discussed with jag on irc...sr=alecf
Assignee | ||
Comment 19•23 years ago
|
||
Checked in, marking fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 20•23 years ago
|
||
I'm not sure how this bug differs from bug 60151 et al (i.e., 61796, 61853, 61991, 68227, 68230, etc.). Those bugs deal with individual items in the UI which are not being updated and they are still not fixed, so how can this one be marked fixed?
Assignee | ||
Comment 21•23 years ago
|
||
Steve and I found out that this was actually a regression caused by my checkin on 2001-04-14 for bug 46200. Leaving this bug fixed, dealing with that issue in bug 60151.
Comment 22•23 years ago
|
||
Patty, can you see how this is working now on Linux and Mac?
Comment 23•23 years ago
|
||
Blake, sorry for responding late. Anyway, I can not verify this bug on Mac, Linux, and windows (2001-05-17-07-Mtrunk) because the classic theme is broken due to switching themes. Will verify the later builds though.
Comment 24•23 years ago
|
||
This one is already fixed. Marking verified on all platforms (commercial build: 2001-06-01-08-trunk).
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•