Closed Bug 68739 Opened 25 years ago Closed 25 years ago

nsIBidiKeyboard.idl related changes

Categories

(Core :: Internationalization, defect, P1)

Product:
Core
Component:
Internationalization
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: ftang, Assigned: erik)

Details

This bug is spin off rom bug 62777 and target on the widget only changes. IBMBIDI team- please attach the latest changes in mozilla/widget directory here and we should land this earlier since the code do not depend on other part and layout chagnes depend on this. kmcclusk@netscape.com nicely agree to review this tomorrow if you can send him by tomorrow morning. Thanks.
Changes look ok to me. r=kmcclusk@netscape.com
I think we need to add nsIBidiKeyboard.idl to MANFIFEST_IDL. Right, Frank? There is a missing backslash (\) in beos/Makefile.in. In the Windows version, when GetKeyboardLayoutList returns an unexpected value, you need to free buf before returning.
OK, I've made changes to my local files, and will check them in. sr=erik
Status: NEW → ASSIGNED
OS: Windows NT → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla0.9
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Stupid question, I expect. Why is it that for all of the platform widgets you have four files in the platform subdirectory - eg. /qt/ but for windows one of the files shows in "mozilla/ widget/ src/ build/ nsWinWidgetFactory.cpp" where the other three are in "mozilla/ widget/ src/ windows/"?
I don't know. The original author(s) of that file (WinWidgetFactory) might know.
Erik, please mark this bug as verified.
QA Contact: teruko → erik
I verified that all of these files were checked in and are being built.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.