69095 - JavaScript URLs from dropdown do not replace location box

Status: VERIFIED FIXED

(SeaMonkey :: Location Bar, defect, P3)

Description

[Tim Powell]

This occurs with Mozilla/5.0 (Windows; U; WinNT4.0; en-US; 0.8) Gecko/20010215.

Steps to reproduce
Type a few urls into the location box. Then type a few javascript URLs into the
location box, such as javascript:alert(document.body.offsetHeight) and
javascript:alert(window.innerHeight). Now using the dropdown list on the
location box, select a previous URL. It switches to the URL and the URL now
appears in the location box. 

Now select a javascript URL from the dropdown. The JavaScript URL should execute
(it does) and it should appear in the location box (it doesn't). Since it
doesn't appear in the box, you can't easily edit previous JavaScript URLs.

I think this is a regression. You used to be able to edit previous JavaScript
URLs. (Although I may think this because it also used to try to autocomplete
javascript urls and it doesn't seem to be doing that now either).

Comment 1

[Jesse Ruderman]

-> urlbar

Comment 2

[Tim Powell]

Adding keywords. This is a regression. It definitely worked in netscape 6 (and 
mozilla .6), and I think it's much more recent than that. Perhaps just before 
mozilla .8? Suggesting mozilla0.9 because this is basically dogfood for me as a 
developer. It's also different than the useful behavior in Netscape 4.x and IE 
4.x+. It acts like there's something explicitly blocking internal protocols 
from being added to the location bar.

Comment 3

[Alec Flett]

reassign url bar bugs to new owner..

Comment 4

[Blake Ross]

Fixed.

For reference, the simple patch was

Index: sessionHistoryUI.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/sessionHistoryUI.js,v
retrieving revision 1.27
diff -u -r1.27 sessionHistoryUI.js
--- sessionHistoryUI.js 2001/09/30 13:38:35     1.27
+++ sessionHistoryUI.js 2001/10/12 00:50:46
@@ -100,7 +100,13 @@
     var label = aTarget.getAttribute("label");
     if (index != "nothing_available" && label)
       {
-        loadURI(getShortcutOrURI(label));
+        var uri = getShortcutOrURI(label);
+        if (gURLBar) {
+          gURLBar.value = uri;
+          BrowserLoadURL();
+        }
+        else
+          loadURI(uri);
       }
   }

this makes us behave like IE and 4.x.

Comment 5

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]