69521 - First launch of browser ignoring URI

Status: VERIFIED FIXED

(Core Graveyard :: Cmd-line Features, defect)

Description

[Becki Sanford]

From Bugzilla Helper:
User-Agent: Mozilla/4.72 [en] (X11; U; Linux 2.4.0-test10 i686)
BuildID:    Build ID 20010207

First launch of browser opens to the "browser.startup.page" instead of the uri
specified in the window.openDialog() arguments.

Reproducible: Always
Steps to Reproduce:
1.Launch the following xul
2.Click on the launch button
3.Browser opens to www.mozilla.org
4.Close browser window
5.Click on launch button a second time
6.Browser opens to www.google.com

Actual Results:  At step 3, browser opens to www.mozilla.org (start page)

Expected Results:  At step 3, expect browser to open to www.google.com

FYI: This broke between build IDs 20010206 and 20010207.

Sample XUL with problem
-----------------------
<?xml version="1.0"?>
<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>

<window id="fooWindow"
        title="browser launch test"
        xmlns:html="http://www.w3.org/TR/REC-html40"
        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
        orient="vertical"
        >

  <box orient="vertical" flex="1">
    <spring style="height:20px;"/>

    <button class="top" value="launch browser"
            onclick="window.openDialog('chrome://navigator/content/', '_blank',
'chrome,dialog=no,all', 'http://www.google.com');"/>
    
    <spring style="height:20px;"/>
  </box>

</window>

Comment 1

[Becki Sanford]

Problem introduced by patch for bug #65993.

Comment 2

[Becki Sanford]

Attachment: Proposed patch for startPage

Comment 3

[Peter "jag" Annema]

What happens when you do something like:

./mozilla -chrome chrome://navigator/content/sample.xul http://slashdot.org/

When you then open the browser window, does it go to Slashdot, or does it go to
the page you specified?

I think it would be better to check for arguments[0], and if that's not defined,
then fall back on the command line url or default url.

Comment 4

[Becki Sanford]

The example you gave goes to www.slashdot.com on launch but I'm trying to launch
a browser from an already open window.  That's where the problem actually lies.

Comment 5

[Peter "jag" Annema]

Right, I understood that. So I was wondering what happens when you open the
browser from an already open window, where that browser is the first one opened
in this session.

Comment 6

[timeless]

remove from asa's plate

Comment 7

[Becki Sanford]

For a test case, I added the button element from my example to the browser's
toolbar and then did the following:

1. ./mozilla -chrome chrome://navigator/content/ http://www.yahoo.com
2. clicked on "launch browser" button
3. a new browser window was opened with the correct URL
4. closed all windows
5. ./mozilla      (which will use the startPage preference)
6. clicked on "launch browser" button
7. a new browser window was opened with the correct URL

Is this the behavior you were questioning?  It appears to work just fine.  Just
run into problems when a non-browser window attempts to use window.openDialog to
get a browser open to a specific URL.

Comment 8

[Peter "jag" Annema]

Right. My point was that if I take your sample xul there, save it in
chrome/comm/content/navigator/sample.xul and do something like:

./mozilla -chrome chrome://navigator/content/sample.xul http://nieuw.nl/

Then click the button from sample.xul to launch the browser, it will start the
browser with http://nieuw.nl/ instead of http://www.google.com/. So your patch
is only a partial fix, and if I recall correctly I put that code you're removing
there because if you do something like:

./mozilla --profile jag http://nieuw.nl/

the URL isn't passed in through window.arguments[0] and I'll need to get it
myself.

Nice mess huh :-) I think I have a short-term solution, let me test that, and
I'll have to talk to some people for a long-term solution.

Comment 9

[Peter "jag" Annema]

Attachment: [patch] give arguments[0] a higher priority

Comment 10

[Jesse Ruderman]

See also bug 61121, "Navigator doesn't go to home page on first startup".

Comment 11

[Peter "jag" Annema]

Becki, did this patch fix things for you?

Comment 12

[Becki Sanford]

I tried the 02/21/01 patch and YES, it did fix the problem I was seeing.  Thanks
for taking care of that!!  Much appreciated!

Comment 13

[Alec Flett]

this sounds right to me
sr=alecf for now

Comment 14

[jag (Peter Annema)]

alecf recently checked in a patch which kinda did this. Is your bug fixed for you?

Comment 15

[Becki Sanford]

Tested with the latest navigator.js (-r1.352) and it appears that, one way or
another, the problem I was having got fixed.

Comment 16

[jag (Peter Annema)]

Becki, I've just checked in a small rewrite of the way urls are opened in the
browser, could you check if this is still fixed for you with a build from after
16:30 pm PDT July 22nd? If so, please mark this bug fixed.

Comment 17

[Becki Sanford]

Retested with Linux nightly build 7/23/2001 (-r1.354 navigator.js) and things
are still working.  Thanks for all your efforts at resolving this bug.  :)

Marking bug as "Fixed"

Comment 18

[sairuh (rarely reading bugmail)]

verifying per comment 17...