696347 - Compact Folders throws error message cmd_compactFolder. TypeError: this._resetThreadPane is not a function

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Alexander Bergmann]

If I try to compact all folders of the current account using "File -> Compact Folders", I get an error message in the Error Console of Thunderbird. (However, the actual compacting is done successfully.)

1. Create a New Profile
2. Add POP account
3. Select any folder, e.g. "Local Folders -> Outbox"
4. "File -> Compact Folders"
5. Open the Error Console ("Tools -> Error Console")

Error: An error occurred executing the cmd_compactFolder command: TypeError: this._resetThreadPane is not a function
Source File: chrome://global/content/globalOverlay.js
Line: 100

Arch Linux / Thunderbird 7.0.1

Comment 1

[:aceman]

Confirming on linux, TB7 and TB8.

Comment 2

[:aceman]

I couldn't find any declaration for the _resetThreadPane() function in the whole comm-central tree. 
The function is called from mail/base/content/folderPane.js line 2300. I don't know what it is supposed to do but the exception probably isn't intentional. Magnus Melin, it seems you merged that line into the file, can you find out what is it for?

Comment 3

[Magnus Melin [:mkmelin]]

Looks like i only changed the indention (and such) - http://hg.mozilla.org/comm-central/diff/2f6ef8daa83e/mail/base/content/folderPane.js. I don't know what it's for. Maybe hg grep can tell... or then it was obsolete when i touched the code already.

Comment 4

[:aceman]

I see now. Can you find out who put it there before? But maybe it is from the time before hg.

Comment 5

[Magnus Melin [:mkmelin]]

Ok, so this is a regression from bug 474701 which removed that function - http://hg.mozilla.org/comm-central/diff/b0e37b312b54/mail/base/content/folderPane.js but forgot to remove it from this one place.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Remove it.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 585128 [details] [diff] [review]
proposed fix

Oops!  Thanks for reporting this and thanks for the fix!

Comment 8

[Magnus Melin [:mkmelin]]

http://hg.mozilla.org/comm-central/rev/e358fbbcf194
->FIXED

Comment 9

[:aceman]

Had this been written in C, the compiler could have caught this.
Is there any such tool (static analysis) for Javascript code in Gecko? Or is it not possible to check for undefined functions in JS?

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to :aceman from comment #9)
> Had this been written in C, the compiler could have caught this.
> Is there any such tool (static analysis) for Javascript code in Gecko? Or is
> it not possible to check for undefined functions in JS?

Joshua ?