Closed Bug 69859 Opened 24 years ago Closed 22 years ago

The NS_OpenURI that returns a nsIChannel is incorrectly named

Categories

(Core :: Networking, defect, P5)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: darin.moz, Assigned: darin.moz)

References

Details

(Keywords: topembed) 

nsNetUtil.h defines 3 versions of NS_OpenURI.  The first returns an unopened
channel, while the latter two call either Open or AsyncOpen to actually open
the channel.  Overloading the function name NS_OpenURI like this is very
confusing.

Opening a URI means opening the channel corresponding to the URI, so NS_OpenURI
should be renamed to something like NS_NewChannel or NS_NewChannelFromURI in
the case that returns a nsIChannel.

The old method would remain (for backwards compatibility), but we should mark
it as depracated and possibly insert a debug warning.
added keyword nsbeta1
Keywords: nsbeta1
Target Milestone: --- → mozilla0.9
Target Milestone: mozilla0.9 → mozilla0.9.1
later
Target Milestone: mozilla0.9.1 → mozilla0.9.2
mass move, v2.
qa to me.
QA Contact: tever → benc
Target Milestone: mozilla0.9.2 → mozilla1.0
Blocks: 104166
Status: NEW → ASSIGNED
Keywords: mozilla1.0
Priority: -- → P5
Keywords: nsbeta1, topembed
my patch for bug 124042 includes the fix for this.
Depends on: 124042
Keywords: nsbeta1+
Keywords: nsbeta1
fixed-on-trunk now that bug 124042 has been fixed on the trunk.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
VERIFIED:
poking around w/ LXR, I see there are currently two NS_OpenURI, as well as a
change in CVS that renamed the 3rd.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.