69869 - Optimize initial reflow case for selects

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Comment 1

[rods (gone)]

accepting

Comment 2

[rods (gone)]

Attachment: patch

Comment 3

[Marc Attinasi]

Patch looks good, but what is with:

+    //lcf->SetPassId(1);
and
+    //lcf->SetPassId(2); ???

I know I am new to layout, but can you document what the passes signify, and why
you are limiting work to certain passes (or at least tell me if it is otherwise
common knowledge)?

Also, what is the purpose of these assertions, and why the constant '100000'?
+    if (NS_FAILED(res)) {
+      NS_ASSERTION(aDesiredSize.width < 100000, "Width is still
NS_UNCONSTRAINEDSIZE");
+      NS_ASSERTION(aDesiredSize.height < 100000, "Height is still
NS_UNCONSTRAINEDSIZE");

pending responses to above queries, sr=attinasi

Comment 4

[Kevin McCluskey (gone)]

patch looks good
r=[e-mail]

Comment 5

[Blake Ross]

Bugzilla strangeness...

Comment 6

[rods (gone)]

What do you mean bugzilla strangeness?

Comment 7

[rods (gone)]

fixed

Comment 8

[bsharma]

QA contact changed to [e-mail]

Comment 9

[Vladimir Ermakov]

verifying per developer's coments