7002 - Speed up mail by removing call to UpdateSummaryTotals

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[scottputterman]

I found that we could speed up mail to take 1/6 of the time to load headers if
we remove the call to UpdateSummaryTotals in OnAddKey.  The side effect of this
is that message counts won't appear correctly in the folder pane and that styles
in the thread pane don't show up correctly until you mouse over the affected
header.  But I think both of these side effects are worth introducing and
figuring out later to get the speed gain.

Comment 1

[scottputterman]

I checked in a fix for this.

Comment 2

[lchiang]

If you fix this for M6, we'll need to document the side effects in the release
notes. Thanks.

Comment 3

[lchiang]

Par or Suresh, can you verify this in the code?

Comment 4

[ppandit]

Scott - in which file(s) is the fix?

Par

Comment 5

[scottputterman]

base\util\nsMsgDBFolder.cpp in the function OnAddKey.  I just commented out the
call to UpdateSummaryTotals. You'll only see the difference if you have to
reparse your mailbox folder.

Comment 6

[leger]

Putting on [Perf] radar

Comment 7

[ppandit]

Current code shows:

NS_IMETHODIMP nsMsgFolder::UpdateSummaryTotals()
{
        //We don't support this
        return NS_OK;
}

VERIFIED as acceptable code