70161 - hook extensions/inspector into the Mac build

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Scott Collins]

OK, I checked in a couple of mac projects and the associated prefixes and
manifests.  Didn't add it to the build, as we'll want smfr's advice on how to
make it optional.  Still need to add optimized libraries to match the debug ones...

Comment 2

[Simon Fraser [no longer active]]

To add an option to the build:
1. Add your new option to mozilla/build/mac/build_scripts/MozillaBuildFlags.txt,
   in the 'options_flags' group. The value there sets the default (on or off).
2. Test your option in the main script (e.g. $main::options{mathml}) to determine
   whether to build projects/manifests.
3. Inform users that they can turn the option on by setting
         options foobar  1
   in their build prefs.

Comment 3

[Peter Van der Beken [:peterv]]

Ugh, these project files are really broken. I've made new ones, will attach them
to the bug tomorrow, together with the necesary build script changes.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: mozilla/extensions/inspector/macbuild/inspectorIDL.mcp

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: mozilla/extensions/inspector/macbuild/inspector.mcp

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: mozilla/extensions/inspector/resources/content/MANIFEST

Comment 7

[Peter Van der Beken [:peterv]]

Attachment: mozilla/extensions/inspector/resources/content/prefs/MANIFEST

Comment 8

[Peter Van der Beken [:peterv]]

Attachment: Patch to build scripts

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: Patch to Document Inspector source files

Comment 10

[Peter Van der Beken [:peterv]]

I've attached the changes I had to make for getting Document Inspector building
and working on Mac. I have moved the .rdf files from the chrome dir to the res
dir, because it's much easier to find the files there from JS (the hack that was
used to find them in the chrome dir didn't work for Mac). So
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=26692 will need to be
reviewed on other platforms too.

Comment 11

[Joe Hewitt (gone)]

Wow, thanks for helping, Peter! I'll review these changes this weekend on
windows and linux.

Comment 12

[Joe Hewitt (gone)]

Everything seems to work fine on Windows after the source changes.  I'll check
all this stuff in this weekend after I finish making some other changes I'm
working on.

Comment 13

[Joe Hewitt (gone)]

I see that peterv has already landed all this

Comment 14

[Peter Van der Beken [:peterv]]

Nope, I didn't. These still need to go in (you wrote you were going to do that):

mozilla/extensions/inspector/resources/content/MANIFEST
mozilla/extensions/inspector/resources/content/prefs/MANIFEST
Patch to Document Inspector source files

I think I'll also need to update the IDL project file, but I'll check. Please
check in these files and then we can finally close the bug :-).

Comment 15

[Joe Hewitt (gone)]

Ok, I just landed all the necessary stuff to make inspector build on mac.  I
have tested it with a debug build, but not optimized since my mac always runs
out of memory when I try to do that.  

Peterv, can you verify this for me?

Comment 16

[Peter Van der Beken [:peterv]]

Just checked in a new version of the InspectorIDL.mcp project to fix the wrong
output path for the headers. Inspector build, I haven't tried it out yet but
marking this fixed and then verified.

Comment 17

[Peter Van der Beken [:peterv]]

Verified.