70809 - [XUL Syntax] Add -moz-box-orient to CSS

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

Move box orientation into CSS.

Comment 1

[David Hyatt]

Attachment: Patch to layout DLL

Comment 2

[David Hyatt]

Attachment: Patch to content DLL

Comment 3

[David Hyatt]

Attachment: Patch to xul.css, moving default orientations into CSS

Comment 4

[David Hyatt]

Ok, this is ready for review.  The subsequent patches to add the remaining six 
properties will be a lot smaller, since this first one adds the new XUL struct 
to the style context and the CSS declaration.

attinasi and brendan, wanna do the honors again? Thanks!  

Note that this code is largely a cut and paste job, exactly emulating the way 
the other structs are defined.  If there's something you don't like about the 
conventions used, etc., please don't blame me, since I'm just blending in. :)

Comment 5

[David Hyatt]

Also note that we have slated that #ifdef INCLUDE_XUL be made to work for 
real.  That is bug 69995.  I was very meticulous about the #ifdefs.

Comment 6

[David Hyatt]

cc'ing pierre also for review.

Comment 7

[Marc Attinasi]

[s]r=attinasi. That's a heck of a migration...

Comment 8

[David Hyatt]

We will also need this struct for a new CSS property that Bill Law needs for
making the application icons skinnable.  -moz-window-icon.  His bug will be
marked dependent on this one, so that he knows when the XUL struct has gone in.

Comment 9

[Brendan Eich [:brendan]]

r=[e-mail].

/be

Comment 10

[David Hyatt]

Fixed.

Comment 11

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Seems like the Bugzilla bug hit this - the bug was marked resolved but not
resolved fixed. I'll reopen and mark it fixed for good (I hope).

Comment 12

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Resolved FIXED.