70810 - [XUL Syntax] Change tab syntax

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

<tabconrol> --> <tabbox>
<tabbox> --> <tabs>
<tabpanel> --> <tabpanels>
<tabpage> --> <tabpanel>

Make a simplified version that allows label attributes to be put on <tabpanel>. 
The tabs can be anonymously built from the labels.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

=> me

Comment 2

[Mark Olson]

Any reason this couldn't be done in two passes, one for the name changes and one
for the syntax updates?  I'll take the renaming and we can go from there, unless
someone objects.

Comment 3

[Mark Olson]

I'll take this.

Comment 4

[David Hyatt]

Two passes would be fun.

Comment 5

[Mark Olson]

Attachment: patch - change tab syntax

Comment 6

[Mark Olson]

The attached patch covers everything, including security (i'll make a separate
patch for that when the time comes).  I'm building to test currently.

<tabpage> (now <tabpanel>) wasn't used anywhere in xul or css, but i changed the
few references anyway.

Comment 7

[Mark Olson]

Attachment: patch - current tip, fixes an issue with cookies and editor

Comment 8

[Mark Olson]

hyatt, ben; feedback, r/sr?

Comment 9

[David Hyatt]

sr=hyatt

We'll need a carpool again for this one.

Comment 10

[Jason Kersey]

I'll look at commercial on this.

Comment 11

[Blake Ross]

cc'ing leaf for carpool magic, possibly experimental build magic also.

Comment 12

[Mark Olson]

Attachment: patch - replace align= w/ orient= (this should be it folks)

Comment 13

[Mark Olson]

Attachment: patch - remove tabs atom per Ben, don't diff vestigal headers

Comment 14

[Mark Olson]

Ben, I'd really appreciate if you could finish reviewing this, it would be nice
to get into 0.9.

hyatt - are you sure we need a carpool for this?  This is relatively contained
and kerz has my back for netscape's commercial tree. (You do have my back right
kerz?)

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

mao, this looks great. Sorry for taking so long to get to this. 
r=ben

Don't think we need a carpool for this, if it's done at a low traffic time 
(e.g. at night). I've done this sort of change before with myself covering 
comm. and caused no problems. 

Comment 16

[Mark Olson]

Attachment: patch - security/ changes

Comment 17

[Mark Olson]

fix checked in.  bryner took care of security, rumor has it kerz handled ns' tree.