70935 - Windows and Linux have space to right of security icon

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[Blake Ross]

Due to the fix from bug 18667 (to ensure that the security lock isn't obscured 
by the mac grow box), the security icon in Classic and Modern is too far to the 
left, resulting in an unsightly disconnect from the edge of the screen.

Comment 1

[andreww]

Accepting.

Comment 2

[Blake Ross]

Any traction on this?

Comment 3

[Blake Ross]

At the very least, can we get rid of the ugly "hole" appearance in Classic?  
The space still exists in Modern, but at least it's styled like the rest of the 
toolbar...

Comment 4

[timeless]

dan: could you set us up to get a grow box?

Comment 5

[andreww]

This will actually be fixed very soon... indirectly.

Comment 6

[andreww]

revisting now that status/task bars are merged.  Looks like implementing Ben's 
resizer widget would help.

Comment 7

[andreww]

Attachment: changes to navigator.xul

Comment 8

[andreww]

blake , et. al. anyone want to review?

Comment 9

[Todd Pringle]

themes triage: moving to 1.0.  

Comment 10

[Blake Ross]

No, I disagree.  If an engineer doesn't have the resources to fix a regression 
he or she causes, then I think the fix should be backed out (provided the 
original fix wasn't significantly more critical than the regression it causes).

That said, the fix for this is easy, I think.  We just need some styling for 
<resizer/>.  (Andrew, looks like the fix attached here was for the other dnd 
bug.)

Comment 11

[andreww]

right - the attachment was for another bug.  Wierd.

The fix for this would be pretty easy to do.

Backing out the changes would be worse because then the security icon 
would be obscured by the mac resizer grippy.

Ill post a proposed fix for this today and see if I can convince PDT to allow 
it.

Comment 12

[Blake Ross]

I will take it and fix it for 0.9.2.

Comment 13

[andreww]

I have a patch ...

Comment 14

[andreww]

Attachment: tiny patch to tasksOverlay.css

Comment 15

[Joe Hewitt (gone)]

sr=hewitt

Comment 16

[Blake Ross]

Thanks! r=blake (fix the newline, please)

Comment 17

[Blake Ross]

(taking)

Comment 18

[andreww]

One last note - this is not fixable on modern skin - because there are no  
platform specific files in modern skin.  But I understand the real issue 
was just with Windows Classic  anyway.  Just making a note...   

Comment 19

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 20

[Blake Ross]

checked in.

Comment 21

[Patty Mac]

Verified the patch.

Comment 22

[Jeremy M. Dolan]

Nothing can be done for modern? It looks strange... not as bad as Classic did,
but definatly looks off, like something belongs there.

Who's figgin' idea was it at Apple to obscure windows with a resize widget?!?

Comment 23

[Lester]

I had thought that this was a fix!!

Speaking as a user, the number of times I had cursed as I accidentally clicked
on the security icon when using the down scroll arrow (poor aim).  When you do,
you have to wait for the security dialog to paint itself, then dismiss it ...

I though it had been moved for usability reasons.  Is there any chance you could
put the progress bar (or even the online/offline icon) under the down button if
you have to have something flush right